unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 68254@debbugs.gnu.org, yvv0@proton.me
Subject: bug#68254: EWW ‘readable’ by default
Date: Mon, 18 Mar 2024 14:37:54 +0200	[thread overview]
Message-ID: <86ttl34swt.fsf@gnu.org> (raw)
In-Reply-To: <6ee278b0-1511-cfd9-7695-7e019d879f7b@gmail.com> (message from Jim Porter on Sun, 17 Mar 2024 12:24:26 -0700)

> Date: Sun, 17 Mar 2024 12:24:26 -0700
> Cc: 68254@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
> 
> Here's a patch for this. It turns 'eww-readable' into a toggle (using 
> the same semantics as minor modes), and also adds an option to prevent 
> adding a new history entry for each call.

Thanks.

> +When called interactively, this command toggles the display of the
> +readable parts.  With a positive prefix argument, always display the
> +readable parts, and with a zero or negative prefix, display the full
> +page.

The imperative form ("display") is what we use in the doc strings, but
it is not really appropriate for the manual.  Here we say "the
function displays" or "it displays" instead, which is consistent with
the first sentence in the above paragraph.

> +(defun eww-readable (&optional arg)
> +  "Toggle display of only the main \"readable\" parts of the current web page.
>  This command uses heuristics to find the parts of the web page that
> -contains the main textual portion, leaving out navigation menus and
> -the like."
> -  (interactive nil eww-mode)
> +contains the main textual portion, leaving out navigation menus and the

"contain" (since it refers to "parts", in plural).

> +If called interactively, toggle the display of the readable parts.  If
> +the prefix argument is positive, display the readable parts, and if it
> +is zero or negative, display the full page.
> +
> +If called from Lisp, toggle the display of the readable parts if ARG is
> +`toggle'.  Display the readable parts if ARG is nil, omitted, or is a
> +positive number.  Display the full page if ARG is a negative number."

This doc string should mention eww-readable-adds-to-history.





  parent reply	other threads:[~2024-03-18 12:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-05  7:35 bug#68254: EWW ‘readable’ by default Navajeeth via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-05 11:52 ` Eli Zaretskii
     [not found]   ` <poNSnv1DQ7L71-FirbCx9nuQ8gqLlPGTIjDYk2pKo2_H3BPuJArYQ2ziQ4pyADSxHCY5cU40D6MUzRqBAZE3pEcFmnzFPD49xunpLyh1UqI=@proton.me>
2024-01-05 13:35     ` Eli Zaretskii
2024-03-17 19:24       ` Jim Porter
2024-03-18  4:32         ` Adam Porter
2024-03-18  5:17           ` Navajeeth via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-18  5:44             ` Jim Porter
2024-03-18  5:18           ` Jim Porter
2024-03-18 12:37         ` Eli Zaretskii [this message]
2024-03-19  0:00           ` Jim Porter
2024-03-21 10:51             ` Eli Zaretskii
2024-03-22  5:46               ` Jim Porter
2024-03-23  7:48                 ` Eli Zaretskii
2024-03-23 17:26                   ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ttl34swt.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68254@debbugs.gnu.org \
    --cc=jporterbugs@gmail.com \
    --cc=yvv0@proton.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).