bug#65069: ispell-region does not preserve the region

bug#65069: ispell-region does not preserve the region

[Sean O'Rourke]

Before Emacs 29.1, selecting a region and running ispell-region would leave point and mark unchanged.  Now it leaves one end of the region at the last place ispell stopped.  I don’t know if this is intended behavior, but it is less convenient than the way it worked before.

Thanks,
Sean

bug#65069: ispell-region does not preserve the region

[Eli Zaretskii]

> From: Sean O'Rourke <sean@drdirtbag.com>
> Date: Fri, 4 Aug 2023 05:21:13 -0600
> 
> Before Emacs 29.1, selecting a region and running ispell-region would leave point and mark unchanged.  Now it leaves one end of the region at the last place ispell stopped.  I don’t know if this is intended behavior, but it is less convenient than the way it worked before.

It was deliberate, see bug#14816 (and the corresponding change to the
doc string of ispell-region).  With Emacs 29.1, the region is left
around the portion of text that was not yet spell-checked, so it is
more useful for continuing spell-checking.  I guess we could add a
user option to avoid doing that, for those who prefer the old
behavior, but is this really needed?

bug#65069: ispell-region does not preserve the region

[Sean O'Rourke]

Thanks for the prompt and thorough response, Eli.  My use case is that I store multiple blog posts in a single file.  When I compose one, I select it, run ispell-region, then copy-paste the corrected text into a webpage.  Ispell changing the region is therefore unhelpful to me, but if that’s an uncommon usage pattern, I can just defadvice it myself to get the old behavior back — no need for another user option.

Sean

> On Aug 5, 2023, at 3:41 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> From: Sean O'Rourke <sean@drdirtbag.com>
>> Date: Fri, 4 Aug 2023 05:21:13 -0600
>> 
>> Before Emacs 29.1, selecting a region and running ispell-region would leave point and mark unchanged.  Now it leaves one end of the region at the last place ispell stopped.  I don’t know if this is intended behavior, but it is less convenient than the way it worked before.
> 
> It was deliberate, see bug#14816 (and the corresponding change to the
> doc string of ispell-region).  With Emacs 29.1, the region is left
> around the portion of text that was not yet spell-checked, so it is
> more useful for continuing spell-checking.  I guess we could add a
> user option to avoid doing that, for those who prefer the old
> behavior, but is this really needed?

bug#65069: ispell-region does not preserve the region

[Eli Zaretskii]

> From: Sean O'Rourke <sean@drdirtbag.com>
> Date: Tue, 8 Aug 2023 20:21:14 -0600
> Cc: 65069@debbugs.gnu.org
> 
> Thanks for the prompt and thorough response, Eli.  My use case is that I store multiple blog posts in a single file.  When I compose one, I select it, run ispell-region, then copy-paste the corrected text into a webpage.  Ispell changing the region is therefore unhelpful to me, but if that’s an uncommon usage pattern, I can just defadvice it myself to get the old behavior back — no need for another user option.

OK, thanks.  I'll leave the bug open so that others who'd like to have
such an option could chime in.  If there's enough demand, I think we
should add it.

bug#65069: ispell-region does not preserve the region

[Juri Linkov]

>> Thanks for the prompt and thorough response, Eli.  My use case is that
>> I store multiple blog posts in a single file.  When I compose one,
>> I select it, run ispell-region, then copy-paste the corrected text into
>> a webpage.  Ispell changing the region is therefore unhelpful to me, but
>> if that’s an uncommon usage pattern, I can just defadvice it myself to
>> get the old behavior back — no need for another user option.
>
> OK, thanks.  I'll leave the bug open so that others who'd like to have
> such an option could chime in.  If there's enough demand, I think we
> should add it.

It would be useful to have two possible values: to leave the
original region selected, or to deactivate the region afterwards
(for example, like 'indent-rigidly' does).