unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Aleksandar Dimitrov <code@aleks.bg>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62204@debbugs.gnu.org
Subject: bug#62204: 30.0.50; Feature Request: treesit-major-mode-hook
Date: Thu, 16 Mar 2023 01:35:17 +0100	[thread overview]
Message-ID: <86pm99y1av.fsf@aleks.bg> (raw)
In-Reply-To: <83wn3iqehe.fsf@gnu.org>


>> Currently, I've found two ways to accomplish loading my functionality for all ts-modes:
>> 
>> - enumerate them all and use their respective hooks
>> - advise something like `treesit-major-mode-setup` to execute my code
>
> Isn't it enough to check that the buffer has a treesit parser?

I'm not sure I understand you, so I'll try to provide some code.

I'd like to be able to do something like this:

(defun my-setup ()
  "Code that depends on the presence of TS")
(add-hook 'treesit-major-mode-hook 'my-setup)

If I understand you correctly,  I could probably do something like this:

(defmacro add-ts-mode-hook (f)
  "Add mode hook that only executes in ts modes"
  `(add-hook 'prog-mode-hook
            (lambda ()
              (when (treesit-language-at (point))
                (,f)))))

I'd say there's bound to be more people who would like to configure a
certain behaviour whenever treesit is available, regardless of major
mode. A macro like the above could be a possible solution, but it
doesn't feel terribly ergonomic.

> A hooks sounds too blunt and ad-hoc for your purposes, AFAIU.

The reason I want to execute my function in a hook is that it sets
buffer local variables, and configures buffer-local behaviour, perhaps
even keybindings. I was under the impression that hooks are the correct
place to do this.







  reply	other threads:[~2023-03-16  0:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-15 11:50 bug#62204: 30.0.50; Feature Request: treesit-major-mode-hook Aleksandar Dimitrov
2023-03-15 14:24 ` Eli Zaretskii
2023-03-16  0:35   ` Aleksandar Dimitrov [this message]
2023-03-16  6:38     ` Eli Zaretskii
2023-03-19 22:35       ` Aleksandar Dimitrov
2023-03-18  7:49 ` Yuan Fu
2023-03-19 22:26   ` Aleksandar Dimitrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86pm99y1av.fsf@aleks.bg \
    --to=code@aleks.bg \
    --cc=62204@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).