From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Aleksandar Dimitrov Newsgroups: gmane.emacs.bugs Subject: bug#62204: 30.0.50; Feature Request: treesit-major-mode-hook Date: Thu, 16 Mar 2023 01:35:17 +0100 Message-ID: <86pm99y1av.fsf@aleks.bg> References: <86cz5adyi9.fsf@aleks.bg> <83wn3iqehe.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32964"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.14; emacs 30.0.50 Cc: 62204@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 16 05:27:38 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcfDE-0008Hc-Lu for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 16 Mar 2023 05:27:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pcfCm-0006dR-1o; Thu, 16 Mar 2023 00:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pcfCi-0006cQ-7S for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 00:27:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pcfCh-0000HA-Pd for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 00:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pcfCh-0005NY-LO for bug-gnu-emacs@gnu.org; Thu, 16 Mar 2023 00:27:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Aleksandar Dimitrov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Mar 2023 04:27:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62204 X-GNU-PR-Package: emacs Original-Received: via spool by 62204-submit@debbugs.gnu.org id=B62204.167894078220605 (code B ref 62204); Thu, 16 Mar 2023 04:27:03 +0000 Original-Received: (at 62204) by debbugs.gnu.org; 16 Mar 2023 04:26:22 +0000 Original-Received: from localhost ([127.0.0.1]:40925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcfC1-0005MC-Qx for submit@debbugs.gnu.org; Thu, 16 Mar 2023 00:26:22 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:39411) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pcbhJ-0007l8-B4 for 62204@debbugs.gnu.org; Wed, 15 Mar 2023 20:42:25 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 438D45C00A7; Wed, 15 Mar 2023 20:42:20 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 15 Mar 2023 20:42:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aleks.bg; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1678927340; x=1679013740; bh=fC /UQOgjbfr/nnSmtqmD1n19DX3JJ0T4St7Db4qFTrk=; b=XwIC/Akmf4PbmdxYVq 9mzzFdUOJIN7OVl/XdVO90mj7SZ8Er02lgTph334wO1UBQRwyEO1N2XT6/q7Abmt WUeoX31wqgxb+E128BbJXxsmlIIeyEg4ZYq2GLv+hsZJInFgoNrFW4ivgf35PEl/ bacud08fuXCzTcBgvPWs9HHHJbXMjOZnmDm83v8mUQYUs1Z0OxyDTtqtQPzYohFk xbMs5M4qWfOWUb2gOk0gvnswYZoSMyae++Bt1RZenWap0eLOY7ogrBHbyAClwh+U Lu5OFW7KjNHaXemSocfja4UEbfZKdj97wA32WCRG0NAztpic0UAgo3J/U0retbMF 4xkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678927340; x=1679013740; bh=fC/UQOgjbfr/n nSmtqmD1n19DX3JJ0T4St7Db4qFTrk=; b=HxU+7YEhrawx2u8NzS2t6gXqKHJhZ yhQ06e/SlIYOXBP9JETzBCRw0GySBE5cFx1Tsd61fI8wy6n61XXjeBpDMPutKi+K oYhQuhfpNiuMgcZS1i0AiZxtDVUApiW/qkj18iv9ZHSno5B2MGxfogxjzm+rIs1o EBITUWVCzRtr3NWfjQ49OIrsM/kScQe+Sk7bOMJkk6BgrF6dix49J4zeBTBsi6Zq o1McMB44JWY4YBq/N+YA4Ruci3Qp18PtZ8CtCSs91TBhxHT+pUImqLkWvCrTULtm mVaG1ZPOgyruYPQpzM0U3IKrKrPrHUAl29hysMwBktyDS6PGaGCJDavxA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvledgvdehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomheptehlvghk shgrnhgurghrucffihhmihhtrhhovhcuoegtohguvgesrghlvghkshdrsghgqeenucggtf frrghtthgvrhhnpeejtedtgffhudefleefieeuieffvefhjefhvdetjeelkeehieejheeu hfetleegkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegtohguvgesrghlvghkshdrsghg X-ME-Proxy: Feedback-ID: i015146a0:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 15 Mar 2023 20:42:19 -0400 (EDT) In-reply-to: <83wn3iqehe.fsf@gnu.org> X-Mailman-Approved-At: Thu, 16 Mar 2023 00:26:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257998 Archived-At: >> Currently, I've found two ways to accomplish loading my functionality for all ts-modes: >> >> - enumerate them all and use their respective hooks >> - advise something like `treesit-major-mode-setup` to execute my code > > Isn't it enough to check that the buffer has a treesit parser? I'm not sure I understand you, so I'll try to provide some code. I'd like to be able to do something like this: (defun my-setup () "Code that depends on the presence of TS") (add-hook 'treesit-major-mode-hook 'my-setup) If I understand you correctly, I could probably do something like this: (defmacro add-ts-mode-hook (f) "Add mode hook that only executes in ts modes" `(add-hook 'prog-mode-hook (lambda () (when (treesit-language-at (point)) (,f))))) I'd say there's bound to be more people who would like to configure a certain behaviour whenever treesit is available, regardless of major mode. A macro like the above could be a possible solution, but it doesn't feel terribly ergonomic. > A hooks sounds too blunt and ad-hoc for your purposes, AFAIU. The reason I want to execute my function in a hook is that it sets buffer local variables, and configures buffer-local behaviour, perhaps even keybindings. I was under the impression that hooks are the correct place to do this.