unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 69305@debbugs.gnu.org
Subject: bug#69305: outline-minor-mode for tabulated-list-mode
Date: Thu, 22 Feb 2024 21:10:45 +0200	[thread overview]
Message-ID: <86plwo1fii.fsf@gnu.org> (raw)
In-Reply-To: <867ciws983.fsf@mail.linkov.net> (message from Juri Linkov on Thu, 22 Feb 2024 19:30:20 +0200)

> From: Juri Linkov <juri@linkov.net>
> Cc: 69305@debbugs.gnu.org
> Date: Thu, 22 Feb 2024 19:30:20 +0200
> 
> >> +@defvar tabulated-list-groups
> >> +This buffer-local variable specifies the groups of entries displayed in
> >> +the Tabulated List buffer.  Its value should be either a list, or a
> >> +function.
> >> +
> >> +If the value is a list, each list element corresponds to one group, and
> >> +should have the form @w{@code{(@var{group-name} @var{entries})}}, where
> >> +@var{group-name} is a string inserted before all group entries, and
> >> +@var{entries} have the same format as @code{tabulated-list-entries}
> >> +(see above).
> >> +
> >> +Otherwise, the value should be a function which returns a list of the
> >> +above form when called with no arguments.
> >> +@end defvar
> >
> > I think the way to specify ENTRIES for this customization should be
> > described in more detail.  Reading the above description, even the
> > idea of using ENTRIES for specifying grouping is unclear, since
> > tabulated-list-entries is basically just a list of column descriptors.
> 
> But ENTRIES are described in 'tabulated-list-entries'.  Here ENTRIES
> are no different from 'tabulated-list-entries' that are just
> column descriptors.

My point is that it isn't obvious how to describe grouping in terms of
column descriptors.  I think the manual should tell in more detail how
to use column descriptors to specify how entries should be grouped.
Maybe an example or two is all that it takes to do that.

> >> +(ert-deftest tabulated-list-groups ()
> >> +  (with-temp-buffer
> >> +    (tabulated-list-mode)
> >> +    (setq tabulated-list-groups
> >> +          (reverse
> >> +           (seq-group-by (lambda (b) (concat "* " (aref (cadr b) 3)))
> >> +                         tabulated-list--test-entries)))
> >> +    (setq tabulated-list-format tabulated-list--test-format)
> >> +    (setq tabulated-list-padding 7)
> >> +    (tabulated-list-init-header)
> >> +    (tabulated-list-print)
> >
> > This seems to test only the function value of tabulated-list-groups?
> > What about the other form of the value?
> 
> The other forms have no functional difference.

Sorry, I don't follow.  Shouldn't we test the capability of specifying
grouping by the method other than by providing a function?





  reply	other threads:[~2024-02-22 19:10 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 17:34 bug#69305: outline-minor-mode for tabulated-list-mode Juri Linkov
2024-02-21 19:12 ` Eli Zaretskii
2024-02-22  7:44   ` Juri Linkov
2024-02-22  8:20     ` Eli Zaretskii
2024-02-22 17:30       ` Juri Linkov
2024-02-22 19:10         ` Eli Zaretskii [this message]
2024-02-23  7:09           ` Juri Linkov
2024-02-23  8:13             ` Eli Zaretskii
2024-02-24 17:43               ` Juri Linkov
2024-02-24 18:09                 ` Eli Zaretskii
2024-02-24 18:13                 ` Eli Zaretskii
2024-02-25  8:00                   ` Adam Porter
2024-02-25 17:25                   ` Juri Linkov
2024-02-25 19:17                     ` Eli Zaretskii
2024-02-27  7:30                       ` Juri Linkov
2024-02-27  8:31                         ` Eli Zaretskii
2024-02-27 17:40                           ` Juri Linkov
2024-02-27 18:44                             ` Eli Zaretskii
2024-02-28  7:36                               ` Juri Linkov
2024-02-28 12:16                                 ` Eli Zaretskii
2024-02-29  7:45                                   ` Juri Linkov
2024-02-29 16:33                                     ` Eli Zaretskii
2024-02-29 17:50                                       ` Juri Linkov
2024-03-03  6:53                                         ` Jean Louis
2024-03-03  7:52                                           ` Juri Linkov
2024-02-24 18:06     ` Ihor Radchenko
2024-02-24 18:16       ` Eli Zaretskii
2024-02-24 18:36         ` Ihor Radchenko
2024-02-24 18:49           ` Eli Zaretskii
2024-02-25  7:45             ` Adam Porter
2024-02-25 17:36               ` Juri Linkov
2024-02-26  3:31                 ` Adam Porter
2024-03-06 17:37                   ` Juri Linkov
2024-03-08 23:13                     ` Adam Porter
2024-02-25  7:53             ` Adam Porter
2024-02-25  8:26               ` Eli Zaretskii
2024-02-25 17:20       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86plwo1fii.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=69305@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).