From: Juri Linkov <juri@linkov.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: 59539@debbugs.gnu.org,
Ramesh Nedunchezian <rameshnedunchezian@outlook.com>
Subject: bug#59539: 29.0.50; Commands created with `insert-kbd-macro` are NOT getting repeated.
Date: Sat, 17 Dec 2022 19:20:56 +0200 [thread overview]
Message-ID: <86mt7myqev.fsf@mail.linkov.net> (raw)
In-Reply-To: <87mt7pngpa.fsf@gmail.com> (Robert Pluim's message of "Thu, 15 Dec 2022 10:45:21 +0100")
>> Do you have an idea how to do the right thing and to guess the user's
>> intention without checking if there are the same keys in the keymap?
>
> I guess it should be possible to find out what the 'original' key
> pressed was. <time passes> How about the below? I guess it changes the
> behaviour when you have a command bound to two keys in the same repeat
> map, and you use the 'wrong' one to repeat
I tested your patch, but then 'C-_' starts the key sequence
'C-_ u u u', whereas we had the users' requests that only 'C-x u'
should start the repeatable sequence by default with 'C-x u u u'.
> (but I could argue that people creating such keymaps should use the
> 'repeat-check-key' property)
For more fine-grained control than 'repeat-check-key', we could support
more properties, for example, define separately only keys that enter
the repeatable sequence, or keys that exit it:
(put 'undo 'repeat-enter-keys '([?\C-x ?u]))
(put 'undo 'repeat-exit-keys '([?\C-_]))
next prev parent reply other threads:[~2022-12-17 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 10:58 bug#59539: 29.0.50; Commands created with `insert-kbd-macro` are NOT getting repeated Ramesh Nedunchezian
2022-12-14 17:13 ` Robert Pluim
2022-12-15 7:20 ` Juri Linkov
2022-12-15 9:45 ` Robert Pluim
2022-12-17 17:20 ` Juri Linkov [this message]
2022-12-27 9:19 ` Ramesh Nedunchezian
2022-12-27 18:06 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86mt7myqev.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=59539@debbugs.gnu.org \
--cc=rameshnedunchezian@outlook.com \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).