From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Juri Linkov <juri@linkov.net>
Newsgroups: gmane.emacs.bugs
Subject: bug#59539: 29.0.50;
 Commands created with `insert-kbd-macro` are NOT getting repeated.
Date: Sat, 17 Dec 2022 19:20:56 +0200
Organization: LINKOV.NET
Message-ID: <86mt7myqev.fsf@mail.linkov.net>
References: <TY2PR0101MB3693EF7ADB9389A508C60A64DA0F9@TY2PR0101MB3693.apcprd01.prod.exchangelabs.com>
 <87v8mdoqn4.fsf@gmail.com> <86tu1xjh1o.fsf@mail.linkov.net>
 <87mt7pngpa.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="398"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
Cc: 59539@debbugs.gnu.org, Ramesh Nedunchezian <rameshnedunchezian@outlook.com>
To: Robert Pluim <rpluim@gmail.com>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 17 18:28:46 2022
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1p6azO-000AYI-5K
	for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Dec 2022 18:28:46 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1p6ayi-000190-Of; Sat, 17 Dec 2022 12:28:04 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1p6ayg-00018B-Oy
 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 12:28:02 -0500
Original-Received: from debbugs.gnu.org ([209.51.188.43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1p6ayg-0001vy-Gs
 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 12:28:02 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1p6ayg-0005eE-9I
 for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 12:28:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Juri Linkov <juri@linkov.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Sat, 17 Dec 2022 17:28:02 +0000
Resent-Message-ID: <handler.59539.B59539.167129807521692@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 59539
X-GNU-PR-Package: emacs
Original-Received: via spool by 59539-submit@debbugs.gnu.org id=B59539.167129807521692
 (code B ref 59539); Sat, 17 Dec 2022 17:28:02 +0000
Original-Received: (at 59539) by debbugs.gnu.org; 17 Dec 2022 17:27:55 +0000
Original-Received: from localhost ([127.0.0.1]:57036 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1p6ayZ-0005do-53
 for submit@debbugs.gnu.org; Sat, 17 Dec 2022 12:27:55 -0500
Original-Received: from relay11.mail.gandi.net ([217.70.178.231]:49877)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@linkov.net>) id 1p6ayX-0005dU-ED
 for 59539@debbugs.gnu.org; Sat, 17 Dec 2022 12:27:53 -0500
Original-Received: (Authenticated sender: juri@linkov.net)
 by mail.gandi.net (Postfix) with ESMTPSA id CEA7D100004;
 Sat, 17 Dec 2022 17:27:45 +0000 (UTC)
In-Reply-To: <87mt7pngpa.fsf@gmail.com> (Robert Pluim's message of "Thu, 15
 Dec 2022 10:45:21 +0100")
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:251297
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/251297>

>> Do you have an idea how to do the right thing and to guess the user's
>> intention without checking if there are the same keys in the keymap?
>
> I guess it should be possible to find out what the 'original' key
> pressed was. <time passes> How about the below? I guess it changes the
> behaviour when you have a command bound to two keys in the same repeat
> map, and you use the 'wrong' one to repeat

I tested your patch, but then 'C-_' starts the key sequence
'C-_ u u u', whereas we had the users' requests that only 'C-x u'
should start the repeatable sequence by default with 'C-x u u u'.

> (but I could argue that people creating such keymaps should use the
> 'repeat-check-key' property)

For more fine-grained control than 'repeat-check-key', we could support
more properties, for example, define separately only keys that enter
the repeatable sequence, or keys that exit it:

  (put 'undo 'repeat-enter-keys '([?\C-x ?u]))
  (put 'undo 'repeat-exit-keys '([?\C-_]))