unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 68235@debbugs.gnu.org
Subject: bug#68235: 29.1.90; Switching tabs stops following process output in selected window
Date: Tue, 05 Mar 2024 19:37:47 +0200	[thread overview]
Message-ID: <86le6wpok4.fsf@mail.linkov.net> (raw)
In-Reply-To: <ddf66e05-519c-4540-8045-22ee544a01ec@gmx.at> (martin rudalics's message of "Mon, 4 Mar 2024 10:40:34 +0100")

>> Patch attached.  I now provide only one hook I called
>> 'window-kept-windows-functions' which is run by both
>> 'set-window-configuration' and 'window-state-put'.
>
> Should be on master now.

In addition to the previous patch I also have more questions:

1. window-kept-windows-functions should be announced in etc/NEWS?

2. window-kept-windows-functions is called too often.
Most of the calls contain just the minibuffer:

   ((#<window 4 on  *Minibuf-0*> #<buffer  *Minibuf-0*> 1 1))

Is it possible not to include the minibuffer window?
So when most of the time this list of kept windows will be empty,
then maybe better to not call the hook at all?

3. Very often the message inserted by the patch that I posted
are quite useless because they look like this:

   This window displayed the buffer #<killed buffer>.

This would be much more informative:

   This window displayed the buffer *Help*.

Maybe 'buffer-last-name' could help to achieve this?

4. I don't understand this part, but maybe this is already correct:

      /* Scan dead buffer windows.  */
      if (!NILP (Vwindow_kept_windows_functions))
	for (; CONSP (dead_windows); dead_windows = XCDR (dead_windows))
	  {
	    window = XCAR (dead_windows);
	    if (WINDOW_LIVE_P (window) && !EQ (window, FRAME_ROOT_WINDOW (f)))
	      delete_deletable_window (window);
	  }

Should it be if(NILP (Vwindow_kept_windows_functions)) instead?
However, this already works correctly in my tests.





  parent reply	other threads:[~2024-03-05 17:37 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-03 20:48 bug#68235: 29.1.90; Switching tabs stops following process output in selected window Dan McCarthy
2024-01-04  6:09 ` Eli Zaretskii
2024-01-04 10:23   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-04 10:42     ` Eli Zaretskii
2024-01-04 17:07     ` Juri Linkov
2024-01-04 17:48       ` Eli Zaretskii
2024-01-05  9:24         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-06 17:36           ` Juri Linkov
2024-01-07 14:54             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-07 16:45               ` Juri Linkov
2024-01-08  8:55                 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-09 17:23                   ` Juri Linkov
2024-01-07 16:49               ` Juri Linkov
2024-01-09 17:25                 ` Juri Linkov
2024-01-10  8:37                   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-10 17:08                     ` Juri Linkov
2024-01-11  9:14                       ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-12  7:37                         ` Juri Linkov
2024-01-13 10:38                           ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 15:02                             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 18:20                               ` Juri Linkov
2024-01-14  8:13                                 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14 18:53                                   ` Juri Linkov
2024-01-15 10:24                                     ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-15 17:53                                       ` Juri Linkov
2024-01-16 10:19                                         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-16 16:30                                           ` Juri Linkov
2024-01-17 11:42                                             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-17 16:36                                               ` Juri Linkov
2024-01-18 10:47                                                 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-18 16:50                                                   ` Juri Linkov
2024-01-20  9:44                                                     ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-22  7:43                                                       ` Juri Linkov
2024-01-23  9:30                                                         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-24  7:54                                                           ` Juri Linkov
2024-01-25  9:39                                                             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-25 17:46                                                               ` Juri Linkov
2024-01-26  9:56                                                                 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-27 17:58                                                                   ` Juri Linkov
2024-01-28 10:06                                                                     ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-05  7:17                                                       ` Juri Linkov
2024-02-06 10:34                                                         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-06 18:03                                                           ` Juri Linkov
2024-02-15  7:34                                                           ` Juri Linkov
2024-02-16  9:40                                                             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-18  7:35                                                               ` Juri Linkov
2024-02-19  9:42                                                                 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-20 17:44                                                                   ` Juri Linkov
2024-03-04  9:40                                                                   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-05 17:27                                                                     ` Juri Linkov
2024-03-05 17:45                                                                       ` Eli Zaretskii
2024-03-06 18:03                                                                         ` Juri Linkov
2024-03-09  8:35                                                                           ` Eli Zaretskii
2024-03-17 17:57                                                                             ` Juri Linkov
2024-03-05 17:37                                                                     ` Juri Linkov [this message]
2024-03-06 10:19                                                                       ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-06 17:57                                                                         ` Juri Linkov
2024-03-08  9:21                                                                           ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 17:23                                                                             ` Juri Linkov
2024-03-11  9:13                                                                               ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09  6:53                                                                                 ` Juri Linkov
2024-04-09  7:36                                                                                   ` Eli Zaretskii
2024-04-09  9:22                                                                                   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 16:40                                                                                     ` Juri Linkov
2024-04-10  8:47                                                                                       ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-10 17:35                                                                                         ` Juri Linkov
2024-04-11  9:16                                                                                           ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-12  6:30                                                                                             ` Juri Linkov
2024-04-12  8:18                                                                                               ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-12 16:20                                                                                                 ` Juri Linkov
2024-04-15  9:21                                                                                                   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-21  6:59                                                                                                     ` Juri Linkov
2024-04-21  8:56                                                                                                       ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-22  6:46                                                                                                         ` Juri Linkov
2024-04-21  9:27                                                                                                       ` Eli Zaretskii
2024-04-22  6:40                                                                                                         ` Juri Linkov
2024-04-22  7:00                                                                                                           ` Eli Zaretskii
2024-04-22 16:36                                                                                                             ` Juri Linkov
2024-04-22 19:22                                                                                                               ` Eli Zaretskii
2024-03-15  9:38                                                                               ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-17 17:47                                                                                 ` Juri Linkov
2024-03-18 10:13                                                                                   ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-15 10:11                                                                             ` Andreas Schwab
2024-03-15 10:56                                                                               ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-04 17:27                       ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86le6wpok4.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=68235@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).