From: Juri Linkov <juri@linkov.net>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 53126@debbugs.gnu.org
Subject: bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc.
Date: Fri, 25 Mar 2022 10:39:12 +0200 [thread overview]
Message-ID: <86ils2mmbe.fsf@mail.linkov.net> (raw)
In-Reply-To: <878rsz6um2.fsf@gmail.com> (Augusto Stoffel's message of "Thu, 24 Mar 2022 20:03:33 +0100")
> @@ -365,14 +372,49 @@ query-replace-read-args
> - (let* ((from (query-replace-read-from prompt regexp-flag))
> - (to (if (consp from) (prog1 (cdr from) (setq from (car from)))
> - (query-replace-read-to from prompt regexp-flag))))
> - (list from to
> - (or (and current-prefix-arg (not (eq current-prefix-arg '-)))
> - (and (plist-member (text-properties-at 0 from) 'isearch-regexp-function)
> - (get-text-property 0 'isearch-regexp-function from)))
> - (and current-prefix-arg (eq current-prefix-arg '-))))))
The name of the function is `query-replace-read-args'.
And now most of the function is dealing with highlighting:
> + (condition-case error
> + (let (;; Variables controlling lazy highlighting while reading
> + ;; FROM and TO.
> + (isearch-case-fold-search case-fold-search)
> + (isearch-lazy-highlight query-replace-lazy-highlight)
> + (isearch-regexp regexp-flag)
> + (isearch-regexp-function (or replace-regexp-function
> + (and current-prefix-arg
> + (not (eq current-prefix-arg '-)))
> + (and replace-char-fold
> + (not regexp-flag)
> + #'char-fold-to-regexp)))
> + (lazy-highlight-cleanup nil)
> + (minibuffer-lazy-highlight-transform
> + (lambda (string)
> + (let* ((split (query-replace--split-string string))
> + (from-string (if (consp split) (car split) split)))
> + (when (and case-fold-search search-upper-case)
> + (setq isearch-case-fold-search
> + (isearch-no-upper-case-p from-string regexp-flag)))
> + from-string)))
> + from to)
> + (when query-replace-lazy-highlight
> + (add-hook 'minibuffer-setup-hook #'minibuffer-lazy-highlight-setup)
> + (when (use-region-p)
> + (letrec ((region-filter (replace--region-filter
> + (funcall region-extract-function 'bounds)))
> + (cleanup (lambda ()
> + (remove-function isearch-filter-predicate region-filter)
> + (remove-hook 'minibuffer-exit-hook cleanup))))
> + (add-function :after-while isearch-filter-predicate region-filter)
> + (add-hook 'minibuffer-exit-hook cleanup))))
> + (setq from (query-replace-read-from prompt regexp-flag))
> + (setq to (if (consp from)
> + (prog1 (cdr from) (setq from (car from)))
> + (query-replace-read-to from prompt regexp-flag)))
> + (list from to
> + (or (and current-prefix-arg (not (eq current-prefix-arg '-)))
> + (and (plist-member (text-properties-at 0 from) 'isearch-regexp-function)
> + (get-text-property 0 'isearch-regexp-function from)))
> + (and current-prefix-arg (eq current-prefix-arg '-))))
> + (t (lazy-highlight-cleanup)
> + (signal (car error) (cdr error))))))
This highlighting needs to be refactored from `query-replace-read-args'
into a separate highlighting function.
next prev parent reply other threads:[~2022-03-25 8:39 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-08 13:24 bug#53126: 29.0.50; [PATCH] Lazy highlight/count when reading query-replace string, etc Augusto Stoffel
2022-01-08 18:59 ` Juri Linkov
2022-01-08 19:35 ` Augusto Stoffel
2022-01-09 9:10 ` Juri Linkov
2022-01-09 10:02 ` Augusto Stoffel
2022-01-09 10:30 ` Augusto Stoffel
2022-01-09 18:58 ` Juri Linkov
2022-01-10 17:34 ` Augusto Stoffel
2022-01-10 19:09 ` Juri Linkov
2022-02-26 16:13 ` Augusto Stoffel
2022-03-15 17:09 ` Juri Linkov
2022-03-15 21:33 ` Augusto Stoffel
2022-03-16 18:56 ` Juri Linkov
2022-03-16 20:09 ` Augusto Stoffel
2022-03-17 17:09 ` Juri Linkov
2022-03-17 19:10 ` Augusto Stoffel
2022-03-17 20:40 ` Juri Linkov
2022-03-17 21:42 ` Augusto Stoffel
2022-03-20 9:38 ` Augusto Stoffel
2022-03-20 18:51 ` Juri Linkov
2022-03-24 19:03 ` Augusto Stoffel
2022-03-25 8:39 ` Juri Linkov [this message]
2022-03-25 9:43 ` Augusto Stoffel
2022-03-27 7:46 ` Juri Linkov
2022-04-01 9:06 ` Augusto Stoffel
2022-04-01 16:35 ` Juri Linkov
2022-04-01 18:12 ` Augusto Stoffel
2022-04-02 18:23 ` Juri Linkov
2022-04-03 8:32 ` Augusto Stoffel
2022-04-03 17:06 ` Juri Linkov
2022-04-04 16:37 ` Juri Linkov
2022-04-05 16:38 ` Augusto Stoffel
2022-04-05 17:12 ` Juri Linkov
2022-04-07 19:32 ` Augusto Stoffel
2022-04-08 7:32 ` Juri Linkov
2022-04-08 7:53 ` Augusto Stoffel
2022-04-09 11:06 ` Augusto Stoffel
2022-04-10 19:38 ` Juri Linkov
2022-03-15 17:24 ` Juri Linkov
2022-03-15 21:21 ` Augusto Stoffel
2022-03-16 19:02 ` Juri Linkov
2022-03-16 20:25 ` Augusto Stoffel
2022-03-17 17:05 ` Juri Linkov
2022-03-17 19:06 ` Augusto Stoffel
2022-03-20 19:24 ` Juri Linkov
2022-03-20 19:59 ` Augusto Stoffel
2022-03-20 20:29 ` Juri Linkov
2022-03-20 20:56 ` Augusto Stoffel
2022-03-23 18:20 ` Juri Linkov
2022-03-23 18:54 ` Augusto Stoffel
2022-03-23 19:17 ` Eli Zaretskii
2022-03-23 19:53 ` Juri Linkov
2022-03-23 20:06 ` Juri Linkov
2022-03-23 20:30 ` Augusto Stoffel
2022-03-23 20:43 ` Juri Linkov
2022-03-17 19:45 ` Augusto Stoffel
2022-03-17 20:43 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ils2mmbe.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=53126@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).