From: Juri Linkov <juri@linkov.net>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eli Zaretskii <eliz@gnu.org>, Filipp Gunbin <fgunbin@fastmail.fm>,
65805@debbugs.gnu.org
Subject: bug#65805: 30.0.50; quoted-insert doesn't work in zap-to-char
Date: Thu, 14 Sep 2023 09:45:05 +0300 [thread overview]
Message-ID: <86h6nxuuby.fsf@mail.linkov.net> (raw)
In-Reply-To: <jwv34zij7p8.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 13 Sep 2023 13:48:34 -0400")
>> @@ -3499,7 +3499,7 @@ read-char-from-minibuffer-map
>> (let ((map (make-sparse-keymap)))
>> (set-keymap-parent map minibuffer-local-map)
>>
>> - (define-key map [remap self-insert-command] #'read-char-from-minibuffer-insert-char)
>> + ;; (define-key map [remap self-insert-command] #'read-char-from-minibuffer-insert-char)
>> (define-key map [remap exit-minibuffer] #'read-char-from-minibuffer-insert-other)
>>
>> Maybe remapping exit-minibuffer is not needed anymore too?
>
> I think it's still needed (RET would otherwise cause exit with an empty
> minibuffer, and hence no "char").
Hmm, maybe then RET should be bound to a command that signals an error
since the behavior is undefined for the case when the minibuffer gets
more characters than one, or when the minibuffer is empty.
>> I see no way to override this. So 'read-char-from-minibuffer-insert-char'
>> can't be replaced with 'self-insert-command'.
>
> Exactly. We could use something like:
>
> (defalias 'read-char-from-minibuffer-insert-char 'self-insert-command)
I have only one doubt how this will affect the users who already bind
this command in own configs. Probably there should be no problems.
>> @@ -3589,7 +3593,15 @@ read-char-from-minibuffer
>> + (result (minibuffer-with-setup-hook
>> + (lambda ()
>> + (add-hook 'post-command-hook
>> + (lambda ()
>> + ;; FIXME: Should we use `<='?
>> + (if (= (1+ (minibuffer-prompt-end))
>> + (point-max))
>> + (exit-minibuffer)))
>> + nil 'local))
>>
>> I think we should use `<=' to handle the case when a string with
>> more than 1 character is pasted with 'C-y'.
>
> Indeed, that's one option. But I was thinking that maybe we should try
> and signal an error. Do the users really expect that yanking a string
> into that prompt will end up picking just the first char of that string?
Picking just the first char looks like a random choice. So indeed maybe
better to signal an error.
next prev parent reply other threads:[~2023-09-14 6:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 14:53 bug#65805: 30.0.50; quoted-insert doesn't work in zap-to-char Filipp Gunbin
2023-09-07 15:07 ` Eli Zaretskii
2023-09-07 16:47 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-07 17:13 ` Juri Linkov
2023-09-07 17:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-13 16:39 ` Juri Linkov
2023-09-13 17:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 6:45 ` Juri Linkov [this message]
2023-09-10 7:17 ` Eli Zaretskii
2023-09-10 23:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-11 11:44 ` Eli Zaretskii
2023-09-12 17:00 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h6nxuuby.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=65805@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=fgunbin@fastmail.fm \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).