From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#65805: 30.0.50; quoted-insert doesn't work in zap-to-char Date: Thu, 14 Sep 2023 09:45:05 +0300 Organization: LINKOV.NET Message-ID: <86h6nxuuby.fsf@mail.linkov.net> References: <834jk6yqbh.fsf@gnu.org> <86msxx3nw9.fsf@mail.linkov.net> <86pm2mtatn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40879"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) Cc: Eli Zaretskii , Filipp Gunbin , 65805@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 14 09:01:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qggLe-000AWo-Jf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Sep 2023 09:01:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qggLS-0006b2-Rx; Thu, 14 Sep 2023 03:00:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qggLR-0006TZ-Hi for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 03:00:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qggLR-0003Qj-9c for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 03:00:57 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qggLW-0006QI-Ua for bug-gnu-emacs@gnu.org; Thu, 14 Sep 2023 03:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Sep 2023 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65805 X-GNU-PR-Package: emacs Original-Received: via spool by 65805-submit@debbugs.gnu.org id=B65805.169467484824644 (code B ref 65805); Thu, 14 Sep 2023 07:01:02 +0000 Original-Received: (at 65805) by debbugs.gnu.org; 14 Sep 2023 07:00:48 +0000 Original-Received: from localhost ([127.0.0.1]:36656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qggLI-0006PQ-1a for submit@debbugs.gnu.org; Thu, 14 Sep 2023 03:00:48 -0400 Original-Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]:55317) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qggLB-0006Ou-KS for 65805@debbugs.gnu.org; Thu, 14 Sep 2023 03:00:42 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id 986A560009; Thu, 14 Sep 2023 07:00:28 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Wed, 13 Sep 2023 13:48:34 -0400") X-GND-Sasl: juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270399 Archived-At: >> @@ -3499,7 +3499,7 @@ read-char-from-minibuffer-map >> (let ((map (make-sparse-keymap))) >> (set-keymap-parent map minibuffer-local-map) >> >> - (define-key map [remap self-insert-command] #'read-char-from-minibuffer-insert-char) >> + ;; (define-key map [remap self-insert-command] #'read-char-from-minibuffer-insert-char) >> (define-key map [remap exit-minibuffer] #'read-char-from-minibuffer-insert-other) >> >> Maybe remapping exit-minibuffer is not needed anymore too? > > I think it's still needed (RET would otherwise cause exit with an empty > minibuffer, and hence no "char"). Hmm, maybe then RET should be bound to a command that signals an error since the behavior is undefined for the case when the minibuffer gets more characters than one, or when the minibuffer is empty. >> I see no way to override this. So 'read-char-from-minibuffer-insert-char' >> can't be replaced with 'self-insert-command'. > > Exactly. We could use something like: > > (defalias 'read-char-from-minibuffer-insert-char 'self-insert-command) I have only one doubt how this will affect the users who already bind this command in own configs. Probably there should be no problems. >> @@ -3589,7 +3593,15 @@ read-char-from-minibuffer >> + (result (minibuffer-with-setup-hook >> + (lambda () >> + (add-hook 'post-command-hook >> + (lambda () >> + ;; FIXME: Should we use `<='? >> + (if (= (1+ (minibuffer-prompt-end)) >> + (point-max)) >> + (exit-minibuffer))) >> + nil 'local)) >> >> I think we should use `<=' to handle the case when a string with >> more than 1 character is pasted with 'C-y'. > > Indeed, that's one option. But I was thinking that maybe we should try > and signal an error. Do the users really expect that yanking a string > into that prompt will end up picking just the first char of that string? Picking just the first char looks like a random choice. So indeed maybe better to signal an error.