bug#70459: Flymake small improvements

bug#70459: Flymake small improvements

[Juri Linkov]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

Tags: patch

1. clicking on flymake fringe indicator will show buffer diagnostics;
2. display diagnostics buffers at the bottom;
3. to do the above there is a need to swap the order
   of generating the buffer contents and displaying the buffer,
   i.e. the same as was done recently in info.el for bug#70213.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: flymake.patch --]
[-- Type: text/x-diff, Size: 1739 bytes --]

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 22a139d3045..f5bf68db574 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1331,7 +1331,10 @@ flymake-start
                   nil))))))))
 
 (defvar flymake-mode-map
-  (let ((map (make-sparse-keymap))) map)
+  (let ((map (make-sparse-keymap)))
+    (define-key map `[,flymake-fringe-indicator-position mouse-1]
+                #'flymake-show-buffer-diagnostics)
+    map)
   "Keymap for `flymake-mode'.")
 
 ;;;###autoload
@@ -1972,8 +1975,12 @@ flymake-show-buffer-diagnostics
                        (current-buffer)))))
     (with-current-buffer target
       (setq flymake--diagnostics-buffer-source source)
-      (display-buffer (current-buffer))
-      (revert-buffer))))
+      (revert-buffer)
+      (display-buffer (current-buffer)
+                      `((display-buffer-reuse-window
+                         display-buffer-below-selected)
+                        (window-height . (lambda (window)
+                          (fit-window-to-buffer window 10))))))))
 
 \f
 ;;; Per-project diagnostic listing
@@ -2073,8 +2080,11 @@ flymake-show-project-diagnostics
     (with-current-buffer buffer
       (flymake-project-diagnostics-mode)
       (setq-local flymake--project-diagnostic-list-project prj)
-      (display-buffer (current-buffer))
-      (revert-buffer))))
+      (revert-buffer)
+      (display-buffer (current-buffer)
+                      `((display-buffer-reuse-window
+                         display-buffer-at-bottom)
+                        (window-height . fit-window-to-buffer))))))
 
 (defun flymake--update-diagnostics-listings (buffer)
   "Update diagnostics listings somehow relevant to BUFFER."

bug#70459: Flymake small improvements

[Juri Linkov]

close 70459 30.0.50
stop

> 1. clicking on flymake fringe indicator will show buffer diagnostics;
> 2. display diagnostics buffers at the bottom;
> 3. to do the above there is a need to swap the order
>    of generating the buffer contents and displaying the buffer,
>    i.e. the same as was done recently in info.el for bug#70213.

This is pushed to master and closed.