From: Eli Zaretskii <eliz@gnu.org>
To: john muhl <jm@pub.pink>
Cc: dmitry@gutov.dev, 70345@debbugs.gnu.org, theo@thornhill.no,
jacobtophatleeming@gmail.com
Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body
Date: Sat, 27 Apr 2024 18:41:59 +0300 [thread overview]
Message-ID: <86h6fmvmm0.fsf@gnu.org> (raw)
In-Reply-To: <875xw2et3e.fsf@pub.pink> (message from john muhl on Sat, 27 Apr 2024 08:10:47 -0500)
> From: john muhl <jm@pub.pink>
> Cc: Jacob Leeming <jacobtophatleeming@gmail.com>, dmitry@gutov.dev,
> 70345@debbugs.gnu.org, theo@thornhill.no
> Date: Sat, 27 Apr 2024 08:10:47 -0500
>
> The test should check that the c-sharp grammar is available so
> that it gets marked as skipped instead of failed.
>
> >From 068cad8612c31cea41f0cc21a865efe0785d4e7a Mon Sep 17 00:00:00 2001
> From: john muhl <jm@pub.pink>
> Date: Sat, 27 Apr 2024 09:55:42 -0500
> Subject: [PATCH] ; Skip 'csharp-ts-mode' test if grammar is missing
>
> * test/lisp/progmodes/csharp-mode-tests.el
> (csharp-ts-mode-test-indentation): Skip test instead of failing.
> ---
> test/lisp/progmodes/csharp-mode-tests.el | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/test/lisp/progmodes/csharp-mode-tests.el b/test/lisp/progmodes/csharp-mode-tests.el
> index 2878fa601f2..b3c57a7026b 100644
> --- a/test/lisp/progmodes/csharp-mode-tests.el
> +++ b/test/lisp/progmodes/csharp-mode-tests.el
> @@ -27,6 +27,7 @@ csharp-mode-test-indentation
> (ert-test-erts-file (ert-resource-file "indent.erts")))
>
> (ert-deftest csharp-ts-mode-test-indentation ()
> + (skip-unless (treesit-ready-p 'c-sharp))
> (ert-test-erts-file (ert-resource-file "indent-ts.erts")))
Thanks, but shouldn't we invoke treesit-ready-p with second argument
non-nil?
next prev parent reply other threads:[~2024-04-27 15:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 20:32 bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body Jacob Leeming
2024-04-12 5:45 ` Eli Zaretskii
2024-04-14 23:02 ` Yuan Fu
2024-04-15 4:56 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 19:01 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 21:38 ` Jacob Leeming
2024-04-16 0:27 ` Dmitry Gutov
2024-04-22 8:50 ` Jacob Leeming
2024-04-25 16:04 ` Eli Zaretskii
2024-04-26 13:53 ` Jacob Leeming
2024-04-26 15:24 ` Eli Zaretskii
2024-04-27 13:10 ` john muhl
2024-04-27 15:41 ` Eli Zaretskii [this message]
2024-04-27 17:13 ` john muhl
2024-04-27 19:18 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86h6fmvmm0.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=70345@debbugs.gnu.org \
--cc=dmitry@gutov.dev \
--cc=jacobtophatleeming@gmail.com \
--cc=jm@pub.pink \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).