From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body Date: Sat, 27 Apr 2024 18:41:59 +0300 Message-ID: <86h6fmvmm0.fsf@gnu.org> References: <87o7afod31.fsf@gmail.com> <87mspusb5k.fsf@thornhill.no> <87wmopaii8.fsf@gmail.com> <867cgl1la9.fsf@gnu.org> <875xw2et3e.fsf@pub.pink> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6468"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 70345@debbugs.gnu.org, theo@thornhill.no, jacobtophatleeming@gmail.com To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 27 17:42:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0kCV-0001YC-0A for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Apr 2024 17:42:55 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0kCL-0006Xd-89; Sat, 27 Apr 2024 11:42:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0kCJ-0006XN-7u for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 11:42:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0kCI-00023l-UT for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 11:42:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0kCb-0002XV-Oh for bug-gnu-emacs@gnu.org; Sat, 27 Apr 2024 11:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Apr 2024 15:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70345-submit@debbugs.gnu.org id=B70345.17142325509726 (code B ref 70345); Sat, 27 Apr 2024 15:43:01 +0000 Original-Received: (at 70345) by debbugs.gnu.org; 27 Apr 2024 15:42:30 +0000 Original-Received: from localhost ([127.0.0.1]:49528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0kC6-0002Wo-31 for submit@debbugs.gnu.org; Sat, 27 Apr 2024 11:42:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0kC3-0002Wf-HQ for 70345@debbugs.gnu.org; Sat, 27 Apr 2024 11:42:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0kBe-0001uq-Lx; Sat, 27 Apr 2024 11:42:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=THq8nVEW9Ph+4EpUCF25WPxpIdQxwa6rU8jxUD6+4BE=; b=QQC1WP+04TaE zvSw1HK/CmhdOGz9QvJLvrjJsdLbQiINWO91AYVab2i/Qrezf0tDeV6+JEp1eRR/d1Jh6ivf+K8B+ 44s1IjDejYoQi+pEhBLc77TSwppPJ1sbH7RCJ5u7bLEZSfyZEG2ZSnu/p7Ira486uk6k2175QjsGg 6UFVBB0s2Ir8u7XnGIugOQUXRsZ55NSSMpM0odBYyP27syCTBWoUSMmehEGyV4GPUlfW5GEj1KAqk Pho5mbaHB4t0TiNsHNQqqk5TEYh0lPg32G/BpMb1DMPE4HSgH/Yr8PMlAxJSg+TmjPMNyA+0uLsbj JaP/UGeDYkHXnlpNfYq3YA==; In-Reply-To: <875xw2et3e.fsf@pub.pink> (message from john muhl on Sat, 27 Apr 2024 08:10:47 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284054 Archived-At: > From: john muhl > Cc: Jacob Leeming , dmitry@gutov.dev, > 70345@debbugs.gnu.org, theo@thornhill.no > Date: Sat, 27 Apr 2024 08:10:47 -0500 > > The test should check that the c-sharp grammar is available so > that it gets marked as skipped instead of failed. > > >From 068cad8612c31cea41f0cc21a865efe0785d4e7a Mon Sep 17 00:00:00 2001 > From: john muhl > Date: Sat, 27 Apr 2024 09:55:42 -0500 > Subject: [PATCH] ; Skip 'csharp-ts-mode' test if grammar is missing > > * test/lisp/progmodes/csharp-mode-tests.el > (csharp-ts-mode-test-indentation): Skip test instead of failing. > --- > test/lisp/progmodes/csharp-mode-tests.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/lisp/progmodes/csharp-mode-tests.el b/test/lisp/progmodes/csharp-mode-tests.el > index 2878fa601f2..b3c57a7026b 100644 > --- a/test/lisp/progmodes/csharp-mode-tests.el > +++ b/test/lisp/progmodes/csharp-mode-tests.el > @@ -27,6 +27,7 @@ csharp-mode-test-indentation > (ert-test-erts-file (ert-resource-file "indent.erts"))) > > (ert-deftest csharp-ts-mode-test-indentation () > + (skip-unless (treesit-ready-p 'c-sharp)) > (ert-test-erts-file (ert-resource-file "indent-ts.erts"))) Thanks, but shouldn't we invoke treesit-ready-p with second argument non-nil?