From: Juri Linkov <juri@linkov.net>
To: Andrea Greselin <greselin.andrea@gmail.com>
Cc: 52356@debbugs.gnu.org
Subject: bug#52356: 27.2; Isearch prompt changes unexpectedly with char folding enabled
Date: Sun, 19 Dec 2021 19:48:19 +0200 [thread overview]
Message-ID: <86bl1cfpuk.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAJ_oJbZ1WShAL96mbbdc5Quqqe0ApM4FfBtHVzmOo+RsRzuM6A@mail.gmail.com> (Andrea Greselin's message of "Fri, 17 Dec 2021 20:35:50 +0100")
close 52356 29.0.50
thanks
> I’ve tested your latest patch in two ways and in both tests the prompt
> didn’t flicker on adding letters to the search string. So it looks
> fine to me.
Thanks for testing. So now pushed to Emacs 29.
>> A possible variant would be not to flicker too much by
>> transitioning from the message:
>>
>> Pending char-fold I-search: string
>>
>> to
>>
>> 1/20 Pending char-fold I-search: string
>
> If I understand it correctly the jittering there is all due to
> ‘lazy-count-prefix-format’ being non-nil. If you set it to nil (and
> use ‘lazy-count-suffix-format’ to display the counter) then you have
> no jittering at all.
Indeed, there is no jittering when the count is at the end of I-search message.
>> But maybe better not to display "Pending" at all?
>
> I personally don’t like delayed changes to graphical elements, so I’d
> say yes.
>
> Now I'm curious though, what‘s the meaning of “pending” in the context
> of Isearch?
“Pending” was intended to say the current search state might not
correspond to the search string until the user types C-s or C-r
to search for the next match. But this should be obvious
without this prefix message.
prev parent reply other threads:[~2021-12-19 17:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 18:38 bug#52356: 27.2; Isearch prompt changes unexpectedly with char folding enabled Andrea Greselin
2021-12-07 19:23 ` Juri Linkov
2021-12-07 20:07 ` Juri Linkov
2021-12-10 10:41 ` Andrea Greselin
2021-12-11 20:04 ` Juri Linkov
2021-12-11 20:30 ` Andrea Greselin
2021-12-12 17:30 ` Juri Linkov
2021-12-17 19:35 ` Andrea Greselin
2021-12-19 17:48 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86bl1cfpuk.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=52356@debbugs.gnu.org \
--cc=greselin.andrea@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).