From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#52356: 27.2; Isearch prompt changes unexpectedly with char folding enabled Date: Sun, 19 Dec 2021 19:48:19 +0200 Organization: LINKOV.NET Message-ID: <86bl1cfpuk.fsf@mail.linkov.net> References: <868rwwdxrq.fsf@mail.linkov.net> <86tufkch63.fsf@mail.linkov.net> <86tufelxg8.fsf@mail.linkov.net> <86r1ahopzb.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="627"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: 52356@debbugs.gnu.org To: Andrea Greselin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 19 18:50:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mz0K7-000AaU-F5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 18:50:15 +0100 Original-Received: from localhost ([::1]:34472 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mz0K6-0003UB-GR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Dec 2021 12:50:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mz0Ju-0003SI-Qm for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 12:50:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mz0Ju-0002fZ-It for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 12:50:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mz0Ju-0007yl-GC for bug-gnu-emacs@gnu.org; Sun, 19 Dec 2021 12:50:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Dec 2021 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52356 X-GNU-PR-Package: emacs Original-Received: via spool by 52356-submit@debbugs.gnu.org id=B52356.163993614430593 (code B ref 52356); Sun, 19 Dec 2021 17:50:02 +0000 Original-Received: (at 52356) by debbugs.gnu.org; 19 Dec 2021 17:49:04 +0000 Original-Received: from localhost ([127.0.0.1]:48029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz0Ix-0007xM-VL for submit@debbugs.gnu.org; Sun, 19 Dec 2021 12:49:04 -0500 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:35091) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mz0Iv-0007wl-UY; Sun, 19 Dec 2021 12:49:02 -0500 Original-Received: (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C429B60006; Sun, 19 Dec 2021 17:48:52 +0000 (UTC) In-Reply-To: (Andrea Greselin's message of "Fri, 17 Dec 2021 20:35:50 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:222731 Archived-At: close 52356 29.0.50 thanks > I’ve tested your latest patch in two ways and in both tests the prompt > didn’t flicker on adding letters to the search string. So it looks > fine to me. Thanks for testing. So now pushed to Emacs 29. >> A possible variant would be not to flicker too much by >> transitioning from the message: >> >> Pending char-fold I-search: string >> >> to >> >> 1/20 Pending char-fold I-search: string > > If I understand it correctly the jittering there is all due to > ‘lazy-count-prefix-format’ being non-nil. If you set it to nil (and > use ‘lazy-count-suffix-format’ to display the counter) then you have > no jittering at all. Indeed, there is no jittering when the count is at the end of I-search message. >> But maybe better not to display "Pending" at all? > > I personally don’t like delayed changes to graphical elements, so I’d > say yes. > > Now I'm curious though, what‘s the meaning of “pending” in the context > of Isearch? “Pending” was intended to say the current search state might not correspond to the search string until the user types C-s or C-r to search for the next match. But this should be obvious without this prefix message.