unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, 57082@debbugs.gnu.org
Subject: bug#57082: 29.0.50; emacs-news-view-mode breakage
Date: Wed, 10 Aug 2022 10:36:22 +0300	[thread overview]
Message-ID: <86bkssedll.fsf@mail.linkov.net> (raw)
In-Reply-To: <87v8r1xj9u.fsf@gmx.net> (Stephen Berman's message of "Tue, 09 Aug 2022 22:18:53 +0200")

>> Also don't understand why is this change:
>>
>>          (when outline-minor-mode-highlight
>> -          (if (and global-font-lock-mode (font-lock-specified-p major-mode))
>> -              (progn
>> -                (font-lock-add-keywords nil outline-font-lock-keywords t)
>> -                (font-lock-flush))
>> -            (outline-minor-mode-highlight-buffer)))
>> +          (when (and global-font-lock-mode (font-lock-specified-p major-mode))
>> +            (font-lock-add-keywords nil outline-font-lock-keywords t)
>> +            (font-lock-flush))
>> +          (outline-minor-mode-highlight-buffer))
>>
>> `outline-minor-mode-highlight-buffer' is intended only for buffers
>> that don't support font-lock highlighting.
>
> Yes, but with that change, arrows are displayed on first visiting the
> NEWS buffer; without it, they only appear when typing TAB on an outline
> heading.

This change broke fontification e.g. in diff buffers that now
add outline faces on diff hunks.  So we need another solution.
Maybe on first visiting the NEWS buffer better to call
refontification with font-lock-ensure?





  parent reply	other threads:[~2022-08-10  7:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 16:18 bug#57082: 29.0.50; emacs-news-view-mode breakage Stephen Berman
2022-08-09 18:23 ` Lars Ingebrigtsen
2022-08-09 19:18   ` Juri Linkov
2022-08-09 20:18     ` Stephen Berman
2022-08-10  0:03       ` Jim Porter
2022-08-10  7:39         ` Juri Linkov
2022-08-10  8:08           ` Gregory Heytings
2022-08-10  8:10             ` Juri Linkov
2022-08-10  8:24               ` Gregory Heytings
2022-08-10 15:17                 ` Drew Adams
2022-08-10  7:55         ` Stephen Berman
2022-08-10  8:07           ` Juri Linkov
2022-08-12 12:50             ` Lars Ingebrigtsen
2022-08-12 12:49           ` Lars Ingebrigtsen
2022-08-12 12:51         ` Lars Ingebrigtsen
2022-08-10  7:36       ` Juri Linkov [this message]
2022-08-10  8:19         ` Stephen Berman
2022-08-10 18:45           ` Juri Linkov
2022-08-10 18:58             ` Stephen Berman
2022-08-11  6:44               ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86bkssedll.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=57082@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).