From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#57082: 29.0.50; emacs-news-view-mode breakage Date: Wed, 10 Aug 2022 10:36:22 +0300 Organization: LINKOV.NET Message-ID: <86bkssedll.fsf@mail.linkov.net> References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38348"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 10 10:03:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLggM-0009pT-54 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 10:03:14 +0200 Original-Received: from localhost ([::1]:35030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLggK-0004a7-HX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 04:03:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLggA-0004Zx-9M for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56165) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLggA-0006eF-0A for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLgg9-0006t0-Pi for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 04:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Aug 2022 08:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57082 X-GNU-PR-Package: emacs Original-Received: via spool by 57082-submit@debbugs.gnu.org id=B57082.166011856426435 (code B ref 57082); Wed, 10 Aug 2022 08:03:01 +0000 Original-Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:02:44 +0000 Original-Received: from localhost ([127.0.0.1]:45911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgfs-0006sI-5f for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:02:44 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:55641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgfp-0006s3-Ka for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:02:43 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 31ED720008; Wed, 10 Aug 2022 08:02:33 +0000 (UTC) In-Reply-To: <87v8r1xj9u.fsf@gmx.net> (Stephen Berman's message of "Tue, 09 Aug 2022 22:18:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239245 Archived-At: >> Also don't understand why is this change: >> >> (when outline-minor-mode-highlight >> - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) >> - (progn >> - (font-lock-add-keywords nil outline-font-lock-keywords t) >> - (font-lock-flush)) >> - (outline-minor-mode-highlight-buffer))) >> + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) >> + (font-lock-add-keywords nil outline-font-lock-keywords t) >> + (font-lock-flush)) >> + (outline-minor-mode-highlight-buffer)) >> >> `outline-minor-mode-highlight-buffer' is intended only for buffers >> that don't support font-lock highlighting. > > Yes, but with that change, arrows are displayed on first visiting the > NEWS buffer; without it, they only appear when typing TAB on an outline > heading. This change broke fontification e.g. in diff buffers that now add outline faces on diff hunks. So we need another solution. Maybe on first visiting the NEWS buffer better to call refontification with font-lock-ensure?