From: Eli Zaretskii <eliz@gnu.org>
To: Adam Porter <adam@alphapapa.net>
Cc: 69666@debbugs.gnu.org
Subject: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional
Date: Sat, 16 Mar 2024 12:29:59 +0200 [thread overview]
Message-ID: <86a5my79lk.fsf@gnu.org> (raw)
In-Reply-To: <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> (message from Adam Porter on Fri, 15 Mar 2024 19:41:33 -0500)
> Date: Fri, 15 Mar 2024 19:41:33 -0500
> Cc: 69666@debbugs.gnu.org
> From: Adam Porter <adam@alphapapa.net>
>
> > Thanks, I have some minor comments below.
>
> Thanks for your review. Please see the attached patch which addresses
> those three items and is rebased on current master. Please let me know
> if I need to make any further changes.
Thanks, this LGTM. Just a couple of minor nits:
> Subject: [PATCH] (vtable-update-object): Make old-object argument optional
> (Bug#69666)
This is too long for the generated ChangeLog. Since this just
reiterates what the log message below it says, I suggest:
. make the heading more terse, like
'vtable-update-object' can now be called with one argument
. move the bug number to the actual log entry:
* lisp/emacs-lisp/vtable.el (vtable-update-object): Make 'old-object'
argument optional. (Bug#69666)
> +(defun vtable-update-object (table object &optional old-object)
> + "Update OBJECT's representation in TABLE.
> +When OLD-OBJECT is non-nil, replace OLD-OBJECT with OBJECT and display
"When" has a meaning of time, which is not what you mean here. I
suggest to use "If" in these cases.
next prev parent reply other threads:[~2024-03-16 10:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 5:51 bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional Adam Porter
2024-03-14 9:00 ` Eli Zaretskii
2024-03-16 0:41 ` Adam Porter
2024-03-16 10:29 ` Eli Zaretskii [this message]
2024-03-17 4:29 ` Adam Porter
2024-03-21 10:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86a5my79lk.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69666@debbugs.gnu.org \
--cc=adam@alphapapa.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).