From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69666: [PATCH] (vtable-update-object): Make old-object argument optional Date: Sat, 16 Mar 2024 12:29:59 +0200 Message-ID: <86a5my79lk.fsf@gnu.org> References: <29c23366-b37c-422e-81f0-f0508e79460f@alphapapa.net> <867ci5b324.fsf@gnu.org> <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12288"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69666@debbugs.gnu.org To: Adam Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 16 11:30:41 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlRJJ-0002zt-3X for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Mar 2024 11:30:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlRJ7-0001Y3-9P; Sat, 16 Mar 2024 06:30:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlRJ4-0001Xg-7C for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 06:30:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlRJ3-00014l-VF for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 06:30:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rlRJe-0005yR-Hy for bug-gnu-emacs@gnu.org; Sat, 16 Mar 2024 06:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Mar 2024 10:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69666 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69666-submit@debbugs.gnu.org id=B69666.171058504622912 (code B ref 69666); Sat, 16 Mar 2024 10:31:02 +0000 Original-Received: (at 69666) by debbugs.gnu.org; 16 Mar 2024 10:30:46 +0000 Original-Received: from localhost ([127.0.0.1]:54872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlRJN-0005xU-O5 for submit@debbugs.gnu.org; Sat, 16 Mar 2024 06:30:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60656) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlRJM-0005xC-CH for 69666@debbugs.gnu.org; Sat, 16 Mar 2024 06:30:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlRIg-000124-2N; Sat, 16 Mar 2024 06:30:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2YLGH+TyewaL/36AY1Ox1RfQdN+SZlEJWmb2EwI0A74=; b=fPVV9NGsoPTx AbF4VMvKc3jJ022qqxDBkVzK18S+qfGI5C73sVcFRGO9XZGMou4AmRPy8t/nYMlQ7p0vwD+a4tiqA gRtUK99EnVcGuEwVToJmw9AtqqZR1TTk7GhOD5JpqTvzIbM9ix9g7yac10WzawL5moF9KmUkxKpOw YpiIq1QW9D+vQ7wc8IqH47xI26nwD9WeXc6KS0WZorM6CwqJWrUCCGAq7ae4otT7OdcUBZOMDF2sl TPJsiK5s52GokwiHxgY9JbA2kU4Jg1shdQ66IYxYZx5Rqhzf1Ec9OfZk6zH9Fecoj8zRrcUG5T7kP lhyM7r0P/oz+MqLBnXBDjA==; In-Reply-To: <9ffd5d95-163c-4f32-8fcd-5805e6d77655@alphapapa.net> (message from Adam Porter on Fri, 15 Mar 2024 19:41:33 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281714 Archived-At: > Date: Fri, 15 Mar 2024 19:41:33 -0500 > Cc: 69666@debbugs.gnu.org > From: Adam Porter > > > Thanks, I have some minor comments below. > > Thanks for your review. Please see the attached patch which addresses > those three items and is rebased on current master. Please let me know > if I need to make any further changes. Thanks, this LGTM. Just a couple of minor nits: > Subject: [PATCH] (vtable-update-object): Make old-object argument optional > (Bug#69666) This is too long for the generated ChangeLog. Since this just reiterates what the log message below it says, I suggest: . make the heading more terse, like 'vtable-update-object' can now be called with one argument . move the bug number to the actual log entry: * lisp/emacs-lisp/vtable.el (vtable-update-object): Make 'old-object' argument optional. (Bug#69666) > +(defun vtable-update-object (table object &optional old-object) > + "Update OBJECT's representation in TABLE. > +When OLD-OBJECT is non-nil, replace OLD-OBJECT with OBJECT and display "When" has a meaning of time, which is not what you mean here. I suggest to use "If" in these cases.