unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 70413@debbugs.gnu.org
Subject: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing
Date: Wed, 17 Apr 2024 15:04:34 +0300	[thread overview]
Message-ID: <865xwgi4a5.fsf@gnu.org> (raw)
In-Reply-To: <87r0f5otfy.fsf@gmx.net> (message from Stephen Berman on Wed, 17 Apr 2024 00:04:33 +0200)

> From: Stephen Berman <stephen.berman@gmx.net>
> Cc: 70413@debbugs.gnu.org
> Date: Wed, 17 Apr 2024 00:04:33 +0200
> 
> > Thanks; see the attached patch.  I think this user option should also be
> > documented in the Widget manual, so the patch includes that as well.
> > The Widget manual has a node for widget customizations, so I added it
> > there.  But I think it is helpful to mention it also in the node
> > "Widgets and the Buffer", where the tabbing commands `widget-forward'
> > and `widget-backward' are documented, so that patch does that too.  If
> > you confirm this is ok, I'll push the code and doc changes to master.
> >
> > Steve Berman
> 
> ... and here's the patch:

LGTM, with 2 minor comments:

> +@defopt widget-skip-inactive
> +If non-@code{nil}, navigating between widgets by @kbd{M-@key{TAB}}
                                                    ^^^^^^^^^^^^^^^^^
This should probably be @kbd{key{TAB}}.

> +(@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward},
> +also bound to @kbd{M-@key{TAB}}) skips over inactive widgets.
                                   ^
I'd add a comma there.

Thanks.





  reply	other threads:[~2024-04-17 12:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-16  9:20 bug#70413: 30.0.50; FR: skip inactive widgets when tabbing Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-16 12:53 ` Eli Zaretskii
2024-04-16 21:56   ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-16 22:04     ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 12:04       ` Eli Zaretskii [this message]
2024-04-17 13:57         ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 15:42           ` Eli Zaretskii
2024-04-17 17:36             ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-17 17:37               ` Stephen Berman via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865xwgi4a5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=70413@debbugs.gnu.org \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).