From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#70413: 30.0.50; FR: skip inactive widgets when tabbing Date: Wed, 17 Apr 2024 15:04:34 +0300 Message-ID: <865xwgi4a5.fsf@gnu.org> References: <87zfttpstx.fsf@gmx.net> <865xwhjwo3.fsf@gnu.org> <87v84hott7.fsf@gmx.net> <87r0f5otfy.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36544"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70413@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 17 14:06:17 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rx43M-0009Jq-0n for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Apr 2024 14:06:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rx434-0003if-DD; Wed, 17 Apr 2024 08:06:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx42x-0003hL-C7 for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 08:05:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rx42w-0006LU-Ez for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 08:05:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rx439-0000Tl-15 for bug-gnu-emacs@gnu.org; Wed, 17 Apr 2024 08:06:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Apr 2024 12:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70413 X-GNU-PR-Package: emacs Original-Received: via spool by 70413-submit@debbugs.gnu.org id=B70413.17133555131504 (code B ref 70413); Wed, 17 Apr 2024 12:06:02 +0000 Original-Received: (at 70413) by debbugs.gnu.org; 17 Apr 2024 12:05:13 +0000 Original-Received: from localhost ([127.0.0.1]:45941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx42G-0000NO-JN for submit@debbugs.gnu.org; Wed, 17 Apr 2024 08:05:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx42B-0000L1-8w for 70413@debbugs.gnu.org; Wed, 17 Apr 2024 08:05:07 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rx41l-0005z8-Jo; Wed, 17 Apr 2024 08:04:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vpN/ESEAmA3rseacF+lGV/TD9YKWu1XSzRPH8+9fJxc=; b=OjHYcO6QpEVU De7/Rg+GXidpQcw4/+/Uim/WbJuxqqTRtxDv9jIMCCL2NqPflCbb3pKPXmS9XmVsvzhvWuRvoci6I EAkTAcHa/xjeiz2WTJz4iUGxhRs5tfHK4xHTxbpEwJCLfdFuPjcC5pO0Ku6mxYu25ssvSqlQAL5a1 sulghVOFaBXodP7rFM336g1Yj6LWwax3LeUaFDxmXHIFwiT6jq0C0ByjJYfudXYXwYdexiMcI5SWI mJSreI0bPxc7qedhSf9KASzoVxZ2z7ciHIApsw59Tj9Q6cM8cw0Y432DJJCs9W7fmIaa3YlWsqEGu hIxt7+FjZ3kEZ6OxrxuBbA==; In-Reply-To: <87r0f5otfy.fsf@gmx.net> (message from Stephen Berman on Wed, 17 Apr 2024 00:04:33 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283481 Archived-At: > From: Stephen Berman > Cc: 70413@debbugs.gnu.org > Date: Wed, 17 Apr 2024 00:04:33 +0200 > > > Thanks; see the attached patch. I think this user option should also be > > documented in the Widget manual, so the patch includes that as well. > > The Widget manual has a node for widget customizations, so I added it > > there. But I think it is helpful to mention it also in the node > > "Widgets and the Buffer", where the tabbing commands `widget-forward' > > and `widget-backward' are documented, so that patch does that too. If > > you confirm this is ok, I'll push the code and doc changes to master. > > > > Steve Berman > > ... and here's the patch: LGTM, with 2 minor comments: > +@defopt widget-skip-inactive > +If non-@code{nil}, navigating between widgets by @kbd{M-@key{TAB}} ^^^^^^^^^^^^^^^^^ This should probably be @kbd{key{TAB}}. > +(@code{widget-forward}) or @kbd{S-@key{TAB}} (@code{widget-backward}, > +also bound to @kbd{M-@key{TAB}}) skips over inactive widgets. ^ I'd add a comma there. Thanks.