bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

[Arash Esbati]

[-- Attachment #1: Type: text/plain, Size: 285 bytes --]

Hi all,

I think some tool bar variables from Gnus are gone, namely
gnus-use-toolbar, gnus-toolbar-thickness and gnus-summary-mail-toolbar.
gnus-{group,summary}-toolbar are now gnus-{group,summary}-tool-bar.

Please find attached a small patch fixing this in Gnus manual.

Best, Arash

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus.texi.patch --]
[-- Type: text/x-patch, Size: 1823 bytes --]

diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi
index 306d66de64..487f524fd2 100644
--- a/doc/misc/gnus.texi
+++ b/doc/misc/gnus.texi
@@ -24139,37 +24139,22 @@ Gravatars
 @end lisp
 
 
-@subsubsection Toolbar
+@subsubsection Tool bar
 
 @table @code
 
-@item gnus-use-toolbar
-@vindex gnus-use-toolbar
-This variable specifies the position to display the toolbar.  If
-@code{nil}, don't display toolbars.  If it is non-@code{nil}, it should
-be one of the symbols @code{default}, @code{top}, @code{bottom},
-@code{right}, and @code{left}.  @code{default} means to use the default
-toolbar, the rest mean to display the toolbar on the place which those
-names show.  The default is @code{default}.
-
-@item gnus-toolbar-thickness
-@vindex gnus-toolbar-thickness
-Cons of the height and the width specifying the thickness of a toolbar.
-The height is used for the toolbar displayed on the top or the bottom,
-the width is used for the toolbar displayed on the right or the left.
-The default is that of the default toolbar.
-
-@item gnus-group-toolbar
+@item gnus-group-tool-bar
 @vindex gnus-group-toolbar
-The toolbar in the group buffer.
+Specifies the tool bar in the group buffer.  It can be either a list
+or a symbol referring to a list.  Pre-defined symbols include
+@code{gnus-group-tool-bar-gnome} and @code{gnus-group-tool-bar-retro}.
 
-@item gnus-summary-toolbar
+@item gnus-summary-tool-bar
 @vindex gnus-summary-toolbar
-The toolbar in the summary buffer.
-
-@item gnus-summary-mail-toolbar
-@vindex gnus-summary-mail-toolbar
-The toolbar in the summary buffer of mail groups.
+Specifies the tool bar in the summary buffer.  It can be either a list
+or a symbol referring to a list.  Pre-defined symbols include
+@code{gnus-summary-tool-bar-gnome} and
+@code{gnus-summary-tool-bar-retro}.
 
 @end table
 

bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

[Eric Abrahamsen]

Arash Esbati <arash@gnu.org> writes:

> Hi all,
>
> I think some tool bar variables from Gnus are gone, namely
> gnus-use-toolbar, gnus-toolbar-thickness and gnus-summary-mail-toolbar.
> gnus-{group,summary}-toolbar are now gnus-{group,summary}-tool-bar.

I wonder if the gnome and retro tool bars are even in effect any more?
It seems to be "retro" by default, but if I turn tool-bar-mode on and
switch `gnus-group-tool-bar' to gnome and back, nothing happens.

bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

[Lars Ingebrigtsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I wonder if the gnome and retro tool bars are even in effect any more?
> It seems to be "retro" by default, but if I turn tool-bar-mode on and
> switch `gnus-group-tool-bar' to gnome and back, nothing happens.

I think there's a bug report about that somewhere...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

[Eric Abrahamsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> I wonder if the gnome and retro tool bars are even in effect any more?
>> It seems to be "retro" by default, but if I turn tool-bar-mode on and
>> switch `gnus-group-tool-bar' to gnome and back, nothing happens.
>
> I think there's a bug report about that somewhere...

I can't find anything with a quick bug search...

bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

[Lars Ingebrigtsen]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> I can't find anything with a quick bug search...

Me neither.  But I remember vaguely there was some discussion about
removing the...  retro tool bar stuff, I guess, since switching doesn't
work.  Or it only works if you switch before starting Gnus.  Or
something like that.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

[Eric Abrahamsen]

On 02/14/22 23:39 PM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> I can't find anything with a quick bug search...
>
> Me neither.  But I remember vaguely there was some discussion about
> removing the...  retro tool bar stuff, I guess, since switching doesn't
> work.  Or it only works if you switch before starting Gnus.  Or
> something like that.

Oh indeed, you have to restart Gnus. My that's unattractive :)

Anyway, I'll put this patch in and close the bug (thank you Arash!). I'm
not sure the tool-bar switching issue is worth attacking at the moment...

bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

[Eric Abrahamsen]

On 02/14/22 14:44 PM, Eric Abrahamsen wrote:
> On 02/14/22 23:39 PM, Lars Ingebrigtsen wrote:
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>>> I can't find anything with a quick bug search...
>>
>> Me neither.  But I remember vaguely there was some discussion about
>> removing the...  retro tool bar stuff, I guess, since switching doesn't
>> work.  Or it only works if you switch before starting Gnus.  Or
>> something like that.
>
> Oh indeed, you have to restart Gnus. My that's unattractive :)
>
> Anyway, I'll put this patch in and close the bug (thank you Arash!). I'm
> not sure the tool-bar switching issue is worth attacking at the moment...

bug#54004: 29.0.50; [PATCH] Gnus outdated tool bar variables

[Arash Esbati]

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> Anyway, I'll put this patch in and close the bug (thank you Arash!).

Thanks for your quick response.  I pushed a small change fixing the
entries for vindex which I missed to do in my initial patch.

Best, Arash