* bug#38040: Compiler warnings on win32 build
@ 2019-11-03 0:36 Cecilio Pardo
2019-11-09 9:55 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Cecilio Pardo @ 2019-11-03 0:36 UTC (permalink / raw)
To: 38040
Severity: wishlist
Tags: patch
Building with mingw64, there are a couple of warnings about wrong data
types that can be avoided:
diff --git a/nt/addpm.c b/nt/addpm.c
index a8bcd4a5c7..ff169f7d87 100644
--- a/nt/addpm.c
+++ b/nt/addpm.c
@@ -56,13 +56,13 @@ #define COBJMACROS 1
#include "../src/epaths.h"
#endif
-HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, DWORD,
- DWORD);
+HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, ULONG_PTR,
+ ULONG_PTR);
HDDEDATA CALLBACK
DdeCallback (UINT uType, UINT uFmt, HCONV hconv,
HSZ hsz1, HSZ hsz2, HDDEDATA hdata,
- DWORD dwData1, DWORD dwData2)
+ ULONG_PTR dwData1, ULONG_PTR dwData2)
{
return ((HDDEDATA) NULL);
}
diff --git a/nt/ddeclient.c b/nt/ddeclient.c
index e441700397..a63be13f75 100644
--- a/nt/ddeclient.c
+++ b/nt/ddeclient.c
@@ -21,13 +21,13 @@
#include <stdlib.h>
#include <stdio.h>
-HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, DWORD,
- DWORD);
+HDDEDATA CALLBACK DdeCallback (UINT, UINT, HCONV, HSZ, HSZ, HDDEDATA, ULONG_PTR,
+ ULONG_PTR);
HDDEDATA CALLBACK
DdeCallback (UINT uType, UINT uFmt, HCONV hconv,
HSZ hsz1, HSZ hsz2, HDDEDATA hdata,
- DWORD dwData1, DWORD dwData2)
+ ULONG_PTR dwData1, ULONG_PTR dwData2)
{
return ((HDDEDATA) NULL);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* bug#38040: Compiler warnings on win32 build
2019-11-03 0:36 bug#38040: Compiler warnings on win32 build Cecilio Pardo
@ 2019-11-09 9:55 ` Eli Zaretskii
2019-11-10 0:03 ` Cecilio Pardo
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2019-11-09 9:55 UTC (permalink / raw)
To: Cecilio Pardo; +Cc: 38040
> From: Cecilio Pardo <cpardo@imayhem.com>
> Date: Sun, 03 Nov 2019 01:36:41 +0100
>
> Building with mingw64, there are a couple of warnings about wrong data
> types that can be avoided:
Thanks, I installed a slightly different change, because these types
are declared DWORD in mingw.org's MinGW headers. Please see that the
warnings are gone in your build.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#38040: Compiler warnings on win32 build
2019-11-09 9:55 ` Eli Zaretskii
@ 2019-11-10 0:03 ` Cecilio Pardo
2019-11-14 9:18 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Cecilio Pardo @ 2019-11-10 0:03 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 38040, Cecilio Pardo
>> Building with mingw64, there are a couple of warnings about wrong data
>> types that can be avoided:
>
> Thanks, I installed a slightly different change, because these types
> are declared DWORD in mingw.org's MinGW headers. Please see that the
> warnings are gone in your build.
They are gone. Thanks for fixing this.
--
Cecilio Pardo
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#38040: Compiler warnings on win32 build
2019-11-10 0:03 ` Cecilio Pardo
@ 2019-11-14 9:18 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2019-11-14 9:18 UTC (permalink / raw)
To: Cecilio Pardo; +Cc: 38040-done
> From: Cecilio Pardo <cpardo@imayhem.com>
> Cc: Cecilio Pardo <cpardo@imayhem.com>, 38040@debbugs.gnu.org
> Date: Sun, 10 Nov 2019 01:03:51 +0100
>
>
> >> Building with mingw64, there are a couple of warnings about wrong data
> >> types that can be avoided:
> >
> > Thanks, I installed a slightly different change, because these types
> > are declared DWORD in mingw.org's MinGW headers. Please see that the
> > warnings are gone in your build.
>
> They are gone. Thanks for fixing this.
Thanks, closing.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-14 9:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-03 0:36 bug#38040: Compiler warnings on win32 build Cecilio Pardo
2019-11-09 9:55 ` Eli Zaretskii
2019-11-10 0:03 ` Cecilio Pardo
2019-11-14 9:18 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).