bug#32605: [w64] (random) never returns negative

[Andy Moreton <andrewjmoreton@gmail.com>]

On Fri 13 Aug 2021, Eli Zaretskii wrote:

>> From: Andy Moreton <andrewjmoreton@gmail.com>
>> Date: Thu, 12 Aug 2021 21:34:09 +0100
>> 
>> >     int val = ((rand_as183 () << 15) | rand_as183 ());
>> >   #ifdef __x86_64__
>> >     return 2 * val - 0x3FFFFFFF;
>> >   #else
>> >     return val;
>> >   #endif
>> >
>> > Andy, can you test this, please?
>> 
>> That does not produce any negative random numbers within a reasonable
>> number of attempts (a few dozen calls).
>
> Thanks for testing.

You elided the detail of my previous message:

  Surely real the problem is that RAND_BITS is 31, but the random() in
  w32.c does not provide 31 random bits (and thus fails to meet the API
  contract).

  In 32bit builds this problem is hidden because 30 bits are sufficient
  for a fixnum, so the value of bit30 in the result is ignored.

  On 64bit builds, 62 bits are needed for a fixnum, and trying to assemble
  a random number from multiple components does not work if RAND_BITS says
  31 bits are usable, but the highest bit in that value is always zero.

Please answer that. This function appears to not work properly at all.

>> Instead, calling rand_as183 again (as below) does produce positive and
>> negative random numbers on 32bit and 64bit builds with a similar number
>> of attempts:
>> 
>> return ((rand_as183 () << 30) | (rand_as183 () << 15) | rand_as183 ());
>> 
>> While this may be less efficient, it at least meets the contract of
>> providing 31 random bits.
>
> What about the variant below, does it produce better results?
>
>     int val = ((rand_as183 () << 15) | rand_as183 ());
>   #ifdef __x86_64__
>     return 2 * val - 0x7FFFFFFF;
>   #else
>     return val;
>   #endif

Why is this any better ? On 32bit builds it does not return 31 random
bits (only a 30bit value) and on 64bit builds the lowest bit is not
random.

I'm not sure I see the point of this bit manipulation as it does not
spread randomness throughout the bits in the returned value.

    AndyM