From: Noam Postavsky <npostavs@gmail.com>
To: Alex Branham <alex.branham@gmail.com>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
Marco Wahl <marcowahlsoft@gmail.com>,
26328@debbugs.gnu.org
Subject: bug#26328: 26.0.50; checkdoc action for join lines drops final "
Date: Fri, 16 Aug 2019 09:42:39 -0400 [thread overview]
Message-ID: <858srtkz00.fsf@gmail.com> (raw)
In-Reply-To: <874l2hdz06.fsf@gmail.com> (Alex Branham's message of "Fri, 16 Aug 2019 08:24:25 -0500")
Alex Branham <alex.branham@gmail.com> writes:
> On Thu 15 Aug 2019 at 20:11, Noam Postavsky <npostavs@gmail.com> wrote:
>
>> Note that the checkdoc-autofix-ask-replace is already replacing the
>> newline with a space (which is kind of a strange behaviour, IMO, but
>> that's how it is currently), so I'm not sure it makes much sense to call
>> delete-indentation after.
>
> Ah, indeed. Starting with this buffer:
>
> (defun foo ()
> "bla bla
> bla."
> )
>
> (defun foo ()
> "Bla bla
> bla bla. More words
> bla bla bla.")
>
> If we just remove the call to delete-indentation we wind up with:
>
> (defun foo ()
> "Bla bla bla."
> )
>
> (defun foo ()
> "Bla bla bla bla.
> More words bla bla bla.")
>
> So perhaps the we just remove that bit? Updated patch attached.
> + (when (checkdoc-autofix-ask-replace
> + p (1+ p)
> + "1st line not a complete sentence. Join these lines? "
> + " " t)
> + (setq msg nil)))))
This is like Lars' suggestion, and using this I get
(defun foo ()
"Bla bla bla bla. More words
bla bla bla.")
for the second case which is incorrect, I think.
next prev parent reply other threads:[~2019-08-16 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 8:51 bug#26328: 26.0.50; checkdoc action for join lines drops final " Marco Wahl
2019-07-26 10:51 ` Lars Ingebrigtsen
2019-07-28 14:05 ` Noam Postavsky
2019-07-29 11:09 ` Lars Ingebrigtsen
2019-08-15 23:13 ` Alex Branham
2019-08-15 23:18 ` Lars Ingebrigtsen
2019-08-16 0:11 ` Noam Postavsky
2019-08-16 13:24 ` Alex Branham
2019-08-16 13:42 ` Noam Postavsky [this message]
2019-08-16 13:55 ` Alex Branham
2019-08-16 14:01 ` Noam Postavsky
2019-08-16 20:54 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=858srtkz00.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=26328@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
--cc=larsi@gnus.org \
--cc=marcowahlsoft@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).