From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#26328: 26.0.50; checkdoc action for join lines drops final " Date: Fri, 16 Aug 2019 09:42:39 -0400 Message-ID: <858srtkz00.fsf@gmail.com> References: <84y3vkqzmd.fsf@tm6592> <878sslnk5w.fsf@mouse.gnus.org> <8736iquuda.fsf@gmail.com> <877e7eowe2.fsf@gmail.com> <87r25motp4.fsf@gmail.com> <874l2hdz06.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207651"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt) Cc: Lars Ingebrigtsen , Marco Wahl , 26328@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 16 15:48:01 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hycaH-000rsq-H4 for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 15:48:01 +0200 Original-Received: from localhost ([::1]:56448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hycaG-000425-EW for geb-bug-gnu-emacs@m.gmane.org; Fri, 16 Aug 2019 09:48:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39004) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1hycVT-00081s-E6 for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 09:43:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hycVS-00073n-5N for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 09:43:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44489) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hycVR-00073R-QF for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 09:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hycVR-0001hf-Ll for bug-gnu-emacs@gnu.org; Fri, 16 Aug 2019 09:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Aug 2019 13:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 26328-submit@debbugs.gnu.org id=B26328.15659629696525 (code B ref 26328); Fri, 16 Aug 2019 13:43:01 +0000 Original-Received: (at 26328) by debbugs.gnu.org; 16 Aug 2019 13:42:49 +0000 Original-Received: from localhost ([127.0.0.1]:53310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hycVE-0001hB-TG for submit@debbugs.gnu.org; Fri, 16 Aug 2019 09:42:49 -0400 Original-Received: from mail-io1-f44.google.com ([209.85.166.44]:43621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hycVC-0001gv-S8 for 26328@debbugs.gnu.org; Fri, 16 Aug 2019 09:42:47 -0400 Original-Received: by mail-io1-f44.google.com with SMTP id 18so6236669ioe.10 for <26328@debbugs.gnu.org>; Fri, 16 Aug 2019 06:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GsxXmXWxlFyLh5vu5SR7ybVOYxqI4TulXqwyvwBWjhA=; b=jAmq6IXaGGVvnX60lXHAc250/zPwrAMfsEe5+7M/HjXn6PmDGzhNxxWnU8GcCC9DTB icCrxDzAZhXqONqQs/vejkN3aHAY+4PP/LRAlCNx1L/EzlsYfpEZAtRobEJQgTZvIht8 d2DMj/oST9RP9e/oW0GinO7SxhI7WPp+ZyjTj8GIkuou+QlDmdtOg0IOfWjteuTse+jl fTW68FNg6TPrB9s2Flgd4ZcWRqP6nZZyzj13ycuohDQVB1NAEzY6J8p7ddINCUgTO2cD Th5KWTIBtf2yj9dFHI1ypowvXFI9jSrl/SbJg5kzyS8YpKYCnoV4YVlIWOAVgxdEhyOJ 93OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GsxXmXWxlFyLh5vu5SR7ybVOYxqI4TulXqwyvwBWjhA=; b=XevOfY4/Jr6CNT3OWSKWpYoY+q7SAsamwJ+axcKLrpHum0zlRm+k4Ca2nUbkQYcZBX LgUshD19npcpdE+lKC9JTVUXdoNFlfvso7QFN+mMCv62f//ToJdyUbZ/5Cx84c1+qDRG 6h1qw87nG0NFRhd90u6pEtdpWoQriQ5EuybMmxBFcrPydWtr1Eip3Cf6Kmimb9t/+85N Ba118Vh+z6S9Vo5u1YlpoWn/VyGoq5Dr7lgxRZ3Tfw/M+EFjMsiC9a7gn5BqepRbHpq3 wzP7k7dJJNTm2E6FRXnLdGfkAMHaJYvJQ6IpbDro9mZJQKQ++fOylDgb+//LHJzzrOGP n+yA== X-Gm-Message-State: APjAAAXVSLHbPLBXxo0PtzPFRlWh8s9Z+YtF28VE4UDsTdzsFOy4Cl1v Sa15pYF8gXn7/8BJf3K4LYJzUNUl X-Google-Smtp-Source: APXvYqwOfZ4EnG8qgY1giTadvAiQQiI0MJUIhExLOqqSGIF6uVkk0AQyjEaLM2cf7dXCh3U+tz0z9w== X-Received: by 2002:a5d:8352:: with SMTP id q18mr10601459ior.154.1565962961148; Fri, 16 Aug 2019 06:42:41 -0700 (PDT) Original-Received: from vhost2 (CPE001143542e1f-CMf81d0f809fa0.cpe.net.cable.rogers.com. [99.230.51.196]) by smtp.gmail.com with ESMTPSA id v13sm8555415iol.60.2019.08.16.06.42.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Aug 2019 06:42:40 -0700 (PDT) In-Reply-To: <874l2hdz06.fsf@gmail.com> (Alex Branham's message of "Fri, 16 Aug 2019 08:24:25 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165206 Archived-At: Alex Branham writes: > On Thu 15 Aug 2019 at 20:11, Noam Postavsky wrote: > >> Note that the checkdoc-autofix-ask-replace is already replacing the >> newline with a space (which is kind of a strange behaviour, IMO, but >> that's how it is currently), so I'm not sure it makes much sense to call >> delete-indentation after. > > Ah, indeed. Starting with this buffer: > > (defun foo () > "bla bla > bla." > ) > > (defun foo () > "Bla bla > bla bla. More words > bla bla bla.") > > If we just remove the call to delete-indentation we wind up with: > > (defun foo () > "Bla bla bla." > ) > > (defun foo () > "Bla bla bla bla. > More words bla bla bla.") > > So perhaps the we just remove that bit? Updated patch attached. > + (when (checkdoc-autofix-ask-replace > + p (1+ p) > + "1st line not a complete sentence. Join these lines? " > + " " t) > + (setq msg nil))))) This is like Lars' suggestion, and using this I get (defun foo () "Bla bla bla bla. More words bla bla bla.") for the second case which is incorrect, I think.