From: Eli Zaretskii <eliz@gnu.org>
To: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
Cc: 27435@debbugs.gnu.org
Subject: bug#27435: patch for dired-mouse-find-file-other-window
Date: Sun, 27 Aug 2017 17:41:30 +0300 [thread overview]
Message-ID: <83zial3wf9.fsf@gnu.org> (raw)
In-Reply-To: <20170827.180243.351755072000785818.tkk@misasa.okayama-u.ac.jp> (message from Tak Kunihiro on Sun, 27 Aug 2017 18:02:43 +0900 (JST))
> Date: Sun, 27 Aug 2017 18:02:43 +0900 (JST)
> Cc: 27435@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp
> From: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
>
> > But you could have the same effect by rebinding mouse-2 to another
> > function. We just need to add such a function, which should work like
> > dired-mouse-find-file-other-window, but visit the file in the same
> > window. That sounds like a better alternative for this use case,
> > because customizing a function-valued variable is trickier for users
> > than rebinding keys.
>
> I agree.
>
> Then the new function `dired-mouse-find-file-this-window' will look
> very similar to `dired-mouse-find-file-other-window' but two lines.
> Is that OK?
We could factor out the common part into a new function, and then make
those two functions call it.
next prev parent reply other threads:[~2017-08-27 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 1:41 bug#27435: patch for dired-mouse-find-file-other-window Tak Kunihiro
2017-07-18 4:38 ` Tak Kunihiro
2017-08-26 6:27 ` Tak Kunihiro
2017-08-26 8:09 ` Eli Zaretskii
2017-08-26 9:26 ` Tak Kunihiro
2017-08-26 10:27 ` Eli Zaretskii
2017-08-27 9:02 ` Tak Kunihiro
2017-08-27 12:56 ` Drew Adams
2017-08-27 14:41 ` Eli Zaretskii [this message]
2017-08-28 0:22 ` Tak Kunihiro
2017-09-02 10:20 ` Eli Zaretskii
2017-09-03 2:08 ` Tak Kunihiro
2017-09-08 8:56 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zial3wf9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=27435@debbugs.gnu.org \
--cc=tkk@misasa.okayama-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).