From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27435: patch for dired-mouse-find-file-other-window Date: Sun, 27 Aug 2017 17:41:30 +0300 Message-ID: <83zial3wf9.fsf@gnu.org> References: <83ziam698h.fsf@gnu.org> <20170826.182658.1910804375178800263.tkk@misasa.okayama-u.ac.jp> <83o9r262uc.fsf@gnu.org> <20170827.180243.351755072000785818.tkk@misasa.okayama-u.ac.jp> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1503844933 24187 195.159.176.226 (27 Aug 2017 14:42:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 27 Aug 2017 14:42:13 +0000 (UTC) Cc: 27435@debbugs.gnu.org To: Tak Kunihiro Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 27 16:42:07 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlylK-0005or-Pz for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Aug 2017 16:42:06 +0200 Original-Received: from localhost ([::1]:32935 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlylP-00040H-Uv for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Aug 2017 10:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlylJ-000401-RF for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 10:42:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlylG-0006bO-PC for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 10:42:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49300) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dlylG-0006bE-L2 for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 10:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dlylG-0007r6-FS for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 10:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Aug 2017 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27435 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 27435-submit@debbugs.gnu.org id=B27435.150384490830175 (code B ref 27435); Sun, 27 Aug 2017 14:42:02 +0000 Original-Received: (at 27435) by debbugs.gnu.org; 27 Aug 2017 14:41:48 +0000 Original-Received: from localhost ([127.0.0.1]:57981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlyl2-0007qd-Fg for submit@debbugs.gnu.org; Sun, 27 Aug 2017 10:41:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43111) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlyl0-0007qQ-3Q for 27435@debbugs.gnu.org; Sun, 27 Aug 2017 10:41:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlykr-0006S4-UR for 27435@debbugs.gnu.org; Sun, 27 Aug 2017 10:41:41 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlykr-0006Ry-Qs; Sun, 27 Aug 2017 10:41:37 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2786 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dlykr-0002Sx-1W; Sun, 27 Aug 2017 10:41:37 -0400 In-reply-to: <20170827.180243.351755072000785818.tkk@misasa.okayama-u.ac.jp> (message from Tak Kunihiro on Sun, 27 Aug 2017 18:02:43 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136261 Archived-At: > Date: Sun, 27 Aug 2017 18:02:43 +0900 (JST) > Cc: 27435@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp > From: Tak Kunihiro > > > But you could have the same effect by rebinding mouse-2 to another > > function. We just need to add such a function, which should work like > > dired-mouse-find-file-other-window, but visit the file in the same > > window. That sounds like a better alternative for this use case, > > because customizing a function-valued variable is trickier for users > > than rebinding keys. > > I agree. > > Then the new function `dired-mouse-find-file-this-window' will look > very similar to `dired-mouse-find-file-other-window' but two lines. > Is that OK? We could factor out the common part into a new function, and then make those two functions call it.