unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 53322@debbugs.gnu.org
Subject: bug#53322: 28.0.91; "C-h c" errors out for menu-bar clicks
Date: Wed, 19 Jan 2022 22:15:50 +0200	[thread overview]
Message-ID: <83zgnrqy6h.fsf@gnu.org> (raw)
In-Reply-To: <8635ljy5vw.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 19 Jan 2022 20:30:31 +0200)

> From: Juri Linkov <juri@linkov.net>
> Cc: 53322@debbugs.gnu.org
> Date: Wed, 19 Jan 2022 20:30:31 +0200
> 
> >       * lisp/help.el (help--analyze-key): Use posn-set-point instead of
> >       mouse-set-point that runs the hook mouse-leave-buffer-hook via
> >       mouse-minibuffer-check.  Using posn-set-point also unnecessitates
> >       extra conditions added in bug#51421.
> >
> > The sad part is that the "unnecessary extra conditions" added in
> > bug#51421 fixed the very problem that your change now reintroduced.
> >
> > Did you test that change with the original recipe which was solved in
> > bug#51421?  Did it work for you back then?
> 
> Naturally, I tested this change with the original recipe from bug#51421.
> And it did work then as well as it's working now.  I don't understand
> where is the problem?

I reported the problem: it's posn-set-point that barfs when the event
is outside of the text area.  The menu-bar menus have some of their
items (the first ones) at coordinates that are outside of the text
area, assuming the tool bar and/or the tab bar are displayed.  So
posn-set-point barfs.





  reply	other threads:[~2022-01-19 20:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 18:03 bug#53322: 28.0.91; "C-h c" errors out for menu-bar clicks Eli Zaretskii
2022-01-17 18:48 ` Eli Zaretskii
2022-01-19 18:30   ` Juri Linkov
2022-01-19 20:15     ` Eli Zaretskii [this message]
2022-01-18 18:25 ` Juri Linkov
2022-01-18 19:41   ` Eli Zaretskii
2022-01-19 18:34     ` Juri Linkov
2022-01-19 20:28       ` Eli Zaretskii
2022-01-19 20:35       ` Eli Zaretskii
2022-01-20 18:44         ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zgnrqy6h.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=53322@debbugs.gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).