From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 60127@debbugs.gnu.org, danny@dfreeman.email, dgutov@yandex.ru
Subject: bug#60127: treesit-end-of-defun: possible bug with clojure grammar
Date: Tue, 17 Jan 2023 14:20:43 +0200 [thread overview]
Message-ID: <83zgah2vz8.fsf@gnu.org> (raw)
In-Reply-To: <A3552170-800F-4F96-8935-929F42941E89@gmail.com> (message from Yuan Fu on Tue, 17 Jan 2023 01:30:22 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Tue, 17 Jan 2023 01:30:22 -0800
> Cc: 60127@debbugs.gnu.org,
> Danny Freeman <danny@dfreeman.email>,
> Eli Zaretskii <eliz@gnu.org>
>
>
> > I’d rather not use treesit_search_dfs, as it does much more work than
> > the current code. You know what, I can write a custom
> > ts_node_first_child_for_byte and use that in Emacs, I’ve already done
> > that for ts_node_parent anyway.
>
> I did that. I tested with the Clojure example and it works fine now.
>
> Eli, we don’t use ts_node_first_child_for_pos for now until tree-sitter
> fix that function, should I removed the boilerplate for it or should I
> leave it as-is? I saw you removed ts_node_parent when I did a similar
> fix.
It should be either removed or #ifdef'ed away, because otherwise GCC
complains in the MS-Windows build about unused macro.
next prev parent reply other threads:[~2023-01-17 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 18:12 bug#60127: treesit-end-of-defun: possible bug with clojure grammar Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-16 23:20 ` Yuan Fu
2022-12-17 14:07 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-17 15:47 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-17 15:47 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-22 8:55 ` Yuan Fu
2023-01-16 1:56 ` Dmitry Gutov
2023-01-16 2:39 ` Yuan Fu
2023-01-17 9:30 ` Yuan Fu
2023-01-17 12:20 ` Eli Zaretskii [this message]
2023-01-17 15:49 ` Danny Freeman via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-05 15:57 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83zgah2vz8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60127@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=danny@dfreeman.email \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).