From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60127: treesit-end-of-defun: possible bug with clojure grammar Date: Tue, 17 Jan 2023 14:20:43 +0200 Message-ID: <83zgah2vz8.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19650"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60127@debbugs.gnu.org, danny@dfreeman.email, dgutov@yandex.ru To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 17 13:21:44 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHkyF-0004vw-C9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 17 Jan 2023 13:21:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pHky1-0004Ug-LU; Tue, 17 Jan 2023 07:21:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHkxc-0004Id-SV for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 07:21:15 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pHkxa-0006CO-DJ for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 07:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pHkxa-0007TI-16 for bug-gnu-emacs@gnu.org; Tue, 17 Jan 2023 07:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jan 2023 12:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60127 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending Original-Received: via spool by 60127-submit@debbugs.gnu.org id=B60127.167395804428682 (code B ref 60127); Tue, 17 Jan 2023 12:21:01 +0000 Original-Received: (at 60127) by debbugs.gnu.org; 17 Jan 2023 12:20:44 +0000 Original-Received: from localhost ([127.0.0.1]:35997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHkxH-0007SX-RA for submit@debbugs.gnu.org; Tue, 17 Jan 2023 07:20:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pHkxE-0007SE-Lq for 60127@debbugs.gnu.org; Tue, 17 Jan 2023 07:20:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHkx8-00064C-9N; Tue, 17 Jan 2023 07:20:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=6DxQabcPlNIjkmggvdDcBIV334UFcf+sYBJd+G9QveY=; b=dSaerCvwJxx/bkHeObGW wue5ZSz7rTs/CUFlTbzYsXXJU5qhKjOebAWaMO+N2nUcJ4RtXw3BhtGAIY8RMGu2VpG6Xv7IJ1Gm4 KiYkwI5FIr+cVBeEVYvzAzOaGkC+YwtFgbKBlssYBcN6rSU6yPHbe4bSTDcUDe9/5pp5WO9z3dpeK RfJ9zF3czDD8IWu00lHjadqGJ+P78wd8+5LpiHNgUFaFcKNwCH8did7rgI2/Epib9aVF0GW/VodPV QwwBH9CTRSxOnLZfydJxujfic0xTr6uPmrfB7lnxe6+IQUhcW9EJ5+2NpwtsKY+ywts5nBixYpT3r WT+IaMqfbBHPQA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pHkx7-0004ka-Eh; Tue, 17 Jan 2023 07:20:34 -0500 In-Reply-To: (message from Yuan Fu on Tue, 17 Jan 2023 01:30:22 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253544 Archived-At: > From: Yuan Fu > Date: Tue, 17 Jan 2023 01:30:22 -0800 > Cc: 60127@debbugs.gnu.org, > Danny Freeman , > Eli Zaretskii > > > > I’d rather not use treesit_search_dfs, as it does much more work than > > the current code. You know what, I can write a custom > > ts_node_first_child_for_byte and use that in Emacs, I’ve already done > > that for ts_node_parent anyway. > > I did that. I tested with the Clojure example and it works fine now. > > Eli, we don’t use ts_node_first_child_for_pos for now until tree-sitter > fix that function, should I removed the boilerplate for it or should I > leave it as-is? I saw you removed ts_node_parent when I did a similar > fix. It should be either removed or #ifdef'ed away, because otherwise GCC complains in the MS-Windows build about unused macro.