unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36065: [PATCH] Mark define-widget-keywords as obsolete
@ 2019-06-02 23:45 Stefan Kangas
  2019-06-09  7:00 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Kangas @ 2019-06-02 23:45 UTC (permalink / raw)
  To: 36065


[-- Attachment #1.1: Type: text/plain, Size: 270 bytes --]

`define-widget-keywords' has been a no-op macro since 1999.

I suggest that we mark it as obsolete.

Please refer to this commit for more information:
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=b3e49cbb9cbb8697a669cc4dbdb60c8e3a1b7a5c

Thanks,
Stefan Kangas

[-- Attachment #1.2: Type: text/html, Size: 456 bytes --]

[-- Attachment #2: 0001-Mark-define-widget-keywords-as-obsolete.patch --]
[-- Type: application/octet-stream, Size: 877 bytes --]

From 4c2df32e238367d3a6cff9325fe50ceab530ab65 Mon Sep 17 00:00:00 2001
From: Stefan Kangas <stefankangas@gmail.com>
Date: Wed, 29 May 2019 19:38:27 +0200
Subject: [PATCH] Mark define-widget-keywords as obsolete

* lisp/widget.el (define-widget-keywords): Mark as obsolete.
---
 lisp/widget.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/widget.el b/lisp/widget.el
index 4028fa1a20..28ba6c6a00 100644
--- a/lisp/widget.el
+++ b/lisp/widget.el
@@ -35,6 +35,7 @@
 ;; Doing this is unnecessary in Emacs 20.  Kept as dummy in case
 ;; external libraries call it.  We save a kb or two of purespace by
 ;; dummying-out such definitions generally.
+(make-obsolete 'define-widget-keywords nil "27.1")
 (defmacro define-widget-keywords (&rest _keys)
   ;; ;; Don't use backquote, since that makes trouble trying to
   ;; ;; re-bootstrap from just the .el files.
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#36065: [PATCH] Mark define-widget-keywords as obsolete
  2019-06-02 23:45 bug#36065: [PATCH] Mark define-widget-keywords as obsolete Stefan Kangas
@ 2019-06-09  7:00 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2019-06-09  7:00 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: 36065-done

> From: Stefan Kangas <stefan@marxist.se>
> Date: Mon, 3 Jun 2019 01:45:02 +0200
> 
> `define-widget-keywords' has been a no-op macro since 1999.
> 
> I suggest that we mark it as obsolete.

Thanks, pushed to the master branch.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-09  7:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-02 23:45 bug#36065: [PATCH] Mark define-widget-keywords as obsolete Stefan Kangas
2019-06-09  7:00 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).