From: Eli Zaretskii <eliz@gnu.org>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 38384@debbugs.gnu.org
Subject: bug#38384: (next|previous)-buffer silent about not switching
Date: Tue, 26 Nov 2019 21:37:02 +0200 [thread overview]
Message-ID: <83y2w2qvj5.fsf@gnu.org> (raw)
In-Reply-To: <CAAeL0SRTa6S1idEDXsL4nvVF6GKoFGEYLdB5G7prWg4Hi=VyVQ@mail.gmail.com> (message from Juanma Barranquero on Tue, 26 Nov 2019 19:51:50 +0100)
> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Tue, 26 Nov 2019 19:51:50 +0100
> Cc: 38384@debbugs.gnu.org
>
> > I don't see how this is relevant to the issue at hand, what did I
> > miss?
>
> Sorry, I fail to see how could it not be relevant. Lisp code calling (next|previous)-buffer already has to defend
> itself against a user-error. My code just adds one specific case (that of the window's buffer list having only one
> buffer) in which user-error is also signaled. Am I missing something?
We previously signaled user-error in situations where we couldn't
continue at all. Your addition is in a situation where nothing
particularly bad happened, so from the POV of a caller, we are now
signaling a user-error gratuitously. I'm bothered only by the change
whereby we signal a user-error with the purpose of attracting the
user's attention, not because we cannot continue.
next prev parent reply other threads:[~2019-11-26 19:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 12:08 bug#38384: (next|previous)-buffer silent about not switching Juanma Barranquero
2019-11-26 13:42 ` martin rudalics
2019-11-26 14:05 ` Juanma Barranquero
2019-11-26 15:42 ` Eli Zaretskii
2019-11-26 15:54 ` Juanma Barranquero
2019-11-26 16:00 ` Juanma Barranquero
2019-11-26 17:00 ` martin rudalics
2019-11-26 18:04 ` Eli Zaretskii
2019-11-26 18:23 ` Juanma Barranquero
2019-11-26 18:44 ` Eli Zaretskii
2019-11-26 18:51 ` Juanma Barranquero
2019-11-26 19:37 ` Eli Zaretskii [this message]
2019-11-26 19:56 ` Juanma Barranquero
2019-11-26 20:07 ` Eli Zaretskii
2019-11-26 17:00 ` martin rudalics
2019-11-26 18:03 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y2w2qvj5.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38384@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).