From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38384: (next|previous)-buffer silent about not switching Date: Tue, 26 Nov 2019 21:37:02 +0200 Message-ID: <83y2w2qvj5.fsf@gnu.org> References: <83lfs2sky2.fsf@gnu.org> <83a78isee4.fsf@gnu.org> <8336eascjk.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="58148"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 38384@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 26 20:38:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iZgf8-000F1F-QJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 20:38:14 +0100 Original-Received: from localhost ([::1]:58378 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZgf7-0007Ur-9L for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Nov 2019 14:38:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36550) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iZgex-0007Rm-AL for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 14:38:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iZgew-0001vI-Cr for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 14:38:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47012) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iZgew-0001v9-9F for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 14:38:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iZgew-0000Ut-7S for bug-gnu-emacs@gnu.org; Tue, 26 Nov 2019 14:38:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2019 19:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38384 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38384-submit@debbugs.gnu.org id=B38384.15747970231838 (code B ref 38384); Tue, 26 Nov 2019 19:38:02 +0000 Original-Received: (at 38384) by debbugs.gnu.org; 26 Nov 2019 19:37:03 +0000 Original-Received: from localhost ([127.0.0.1]:52984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZgdy-0000TP-Tl for submit@debbugs.gnu.org; Tue, 26 Nov 2019 14:37:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:55548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iZgdx-0000Sd-HL for 38384@debbugs.gnu.org; Tue, 26 Nov 2019 14:37:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iZgds-0001Os-7q; Tue, 26 Nov 2019 14:36:56 -0500 Original-Received: from [176.228.60.248] (port=3659 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iZgdr-0004th-JB; Tue, 26 Nov 2019 14:36:56 -0500 In-reply-to: (message from Juanma Barranquero on Tue, 26 Nov 2019 19:51:50 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172474 Archived-At: > From: Juanma Barranquero > Date: Tue, 26 Nov 2019 19:51:50 +0100 > Cc: 38384@debbugs.gnu.org > > > I don't see how this is relevant to the issue at hand, what did I > > miss? > > Sorry, I fail to see how could it not be relevant. Lisp code calling (next|previous)-buffer already has to defend > itself against a user-error. My code just adds one specific case (that of the window's buffer list having only one > buffer) in which user-error is also signaled. Am I missing something? We previously signaled user-error in situations where we couldn't continue at all. Your addition is in a situation where nothing particularly bad happened, so from the POV of a caller, we are now signaling a user-error gratuitously. I'm bothered only by the change whereby we signal a user-error with the purpose of attracting the user's attention, not because we cannot continue.