unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: pillule <pillule@riseup.net>
Cc: 48916@debbugs.gnu.org
Subject: bug#48916: 28.0.50; allow windmove to select windows with the 'no-other-window parameter
Date: Tue, 08 Jun 2021 17:12:08 +0300	[thread overview]
Message-ID: <83y2bke98n.fsf@gnu.org> (raw)
In-Reply-To: <87zgw0xxya.fsf@riseup.net> (message from pillule on Tue, 08 Jun 2021 15:28:34 +0200)

> From: pillule <pillule@riseup.net>
> Cc: pillule <pillule@riseup.net>, 48916@debbugs.gnu.org
> Date: Tue, 08 Jun 2021 15:28:34 +0200
> 
> > This isn't formatted accoring to our rules.  In particular, each
> > sentence after the colon should begin with a capital letter and
> > end with a period.  See CONTRIBUTE for more details (and I suggest
> > to use Emacs commands for writing log messages, as they will take
> > care of some routine parts of the formatting for you).
> 
> So that means you are recommending to use VC instead of Magit 
> (that I used) for committing changes ?
> Maybe Magit have a something that I am not aware for this purpose 
> ?

AFAIK, Magit does have such a command, but don't ask me what it is...

> > Also, I believe we don't  like redundant :group tags, such as 
> > the one here.
> 
> got them. the last one may be a little bit confusing for the 
> reader that is not aware of it because all others defcustoms of 
> window.el applies a :group tag. Do you want that I remove the 
> others unnecessary ones ?

Fine with me if you remove them.

(The patch you sent was the old one, right?)

Thanks.





  reply	other threads:[~2021-06-08 14:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-08 10:09 bug#48916: 28.0.50; allow windmove to select windows with the 'no-other-window parameter pillule
2021-06-08 11:44 ` Eli Zaretskii
2021-06-08 13:28   ` pillule
2021-06-08 14:12     ` Eli Zaretskii [this message]
2021-06-08 14:48       ` Robert Pluim
2021-06-09 17:37         ` pillule
2021-06-09 20:13           ` Juri Linkov
2021-06-10  8:58             ` pillule
2021-06-08 13:57   ` pillule
2021-06-08 14:13     ` Eli Zaretskii
2021-06-08 14:26       ` pillule
2021-06-08 16:46 ` Juri Linkov
2021-06-15 19:50 ` pillule
2021-06-15 23:27   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y2bke98n.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48916@debbugs.gnu.org \
    --cc=pillule@riseup.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).