From: Eli Zaretskii <eliz@gnu.org>
To: pillule <pillule@riseup.net>
Cc: 48916@debbugs.gnu.org
Subject: bug#48916: 28.0.50; allow windmove to select windows with the 'no-other-window parameter
Date: Tue, 08 Jun 2021 14:44:14 +0300 [thread overview]
Message-ID: <83czswfunl.fsf@gnu.org> (raw)
In-Reply-To: <878s3kzm66.fsf@riseup.net> (message from pillule on Tue, 08 Jun 2021 12:09:21 +0200)
> From: pillule <pillule@riseup.net>
> Date: Tue, 08 Jun 2021 12:09:21 +0200
>
> One may want to customize its `display-buffer-alist' carefully to
> apply the 'no-other-window parameter to eg side windows so they
> are not selected by the `other-window' command and to create
> custom functions of the family (eg creating a
> `find-file-in-other-window' that does not select windows with the
> no-other-window parameter)
>
> Unfortunately by doing so, we actually limit the use of the
> windmove commands since `windmove-find-other-window' always ignore
> windows with this parameter.
> It is not a fatality since `window-in-direction' can receive an
> argument to choose if we want to ignore this parameter or not.
>
> This draft implements an user option to let the user choose that
> behavior.
Thanks. I don't use windmove, so I will let others comment. But
please allow me a few minor nits:
> * lisp/windmove.el
> (windmove-ignore-no-other-window): add this new user option
> (windmove-find-other-window): uses windmove-ignore-no-other-window
> to choose whether windmove can access to the window with the
> 'no-other-window property.
This isn't formatted accoring to our rules. In particular, each
sentence after the colon should begin with a capital letter and end
with a period. See CONTRIBUTE for more details (and I suggest to use
Emacs commands for writing log messages, as they will take care of
some routine parts of the formatting for you).
> +(defcustom windmove-ignore-no-other-window nil
This name is not the best one. For starters, "ignore-no" is a kind of
double negation, which makes it harder to understand and remember.
Can you come up with a better description of what exactly is ignored
here?
> + "Whether the windmove commands are allowed to target all type of windows,
The first line of a doc string should be a complete sentence (it is)
and end with a period.
> +If this variable is set to t, `windmove-find-other-window--side' and
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
"If non-nil, ..."
> +subsequently all interactive windmove commandswill ignore the
^^^^^^^^^^^^
A typo.
> +no-other-window parameter."
If you reference this parameter, I think you should say that it's a
parameter to be applied by display-buffer-alist's actions.
> + :type 'boolean
> + :group 'windmove)
New defcustoms should have a :version tag. Also, I believe we don't
like redundant :group tags, such as the one here.
next prev parent reply other threads:[~2021-06-08 11:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 10:09 bug#48916: 28.0.50; allow windmove to select windows with the 'no-other-window parameter pillule
2021-06-08 11:44 ` Eli Zaretskii [this message]
2021-06-08 13:28 ` pillule
2021-06-08 14:12 ` Eli Zaretskii
2021-06-08 14:48 ` Robert Pluim
2021-06-09 17:37 ` pillule
2021-06-09 20:13 ` Juri Linkov
2021-06-10 8:58 ` pillule
2021-06-08 13:57 ` pillule
2021-06-08 14:13 ` Eli Zaretskii
2021-06-08 14:26 ` pillule
2021-06-08 16:46 ` Juri Linkov
2021-06-15 19:50 ` pillule
2021-06-15 23:27 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83czswfunl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48916@debbugs.gnu.org \
--cc=pillule@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).