unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
Cc: 55439@debbugs.gnu.org
Subject: bug#55439: [PATCH] Add support for the Modi script
Date: Mon, 16 May 2022 14:33:55 +0300	[thread overview]
Message-ID: <83y1z1iue4.fsf@gnu.org> (raw)
In-Reply-To: <CAOR1sLwyx1Q=pQW82hYyXyX2mCRE0o41PWgrjsWNP8zEv7mgOA@mail.gmail.com> (lumarzeli30@gmail.com)

> From: समीर सिंह Sameer Singh
>  <lumarzeli30@gmail.com>
> Date: Mon, 16 May 2022 05:03:59 +0530
> 
> I have added the modi script to Emacs this time.

Thanks.

Can you tell how many more old scripts you intend to add?  I'm
thinking perhaps we should make a separate section for them in NEWS,
instead of basically repeating the same text over and over and over
again.

> I have also renamed Hindi to Devanagari in etc/HELLO, since this
> script is also used by languages other than Hindi, like: Marathi and
> Nepali.

I'm okay with the change, but please add the same sample-text to the
Devanagari language environment in indian.el.

> Please review the patch.
> diff --git a/etc/HELLO b/etc/HELLO
> index 16a38b59d3..04014e8dea 100644
> --- a/etc/HELLO
> +++ b/etc/HELLO
> @@ -38,6 +38,7 @@ Comanche /kəˈmæntʃiː/	Haa marʉ́awe
>  Cree (ᓀᐦᐃᔭᐍᐏᐣ)	ᑕᓂᓯ / ᐙᒋᔮ
>  Czech (čeština)	Dobrý den
>  Danish (dansk)	Hej / Goddag / Halløj
> +Devanagari (देवनागरी)	नमस्ते / नमस्कार
>  Dutch (Nederlands)	Hallo / Dag
>  Efik  /ˈɛfɪk/	Mɔkɔm
>  Egyptian Hieroglyphs (𓂋𓏤𓈖𓆎𓅓‌𓏏𓊖)	𓅓𓊵𓏏𓊪, 𓇍𓇋𓂻𓍘𓇋
> @@ -55,7 +57,6 @@ Greek, ancient (ἑλληνική)	Οὖλέ τε καὶ μέγα χαῖρε
>  Gujarati (ગુજરાતી)	નમસ્તે
>  Hebrew (עִבְרִית)	שָׁלוֹם
>  Hungarian (magyar)	Szép jó napot!
> -Hindi (हिंदी)	नमस्ते / नमस्कार ।

The "Hindi" greeting had a character at its end, U+0964, which
disappeared when you moved the line to Devanagari.  Is that
intentional?

> +*** New language environment "Modi"

Period missing at the end of this line.





  parent reply	other threads:[~2022-05-16 11:33 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-15 23:33 bug#55439: [PATCH] Add support for the Modi script समीर सिंह Sameer Singh
2022-05-16  7:00 ` Pankaj Jangid
2022-05-17 22:57   ` Richard Stallman
2022-05-16 11:33 ` Eli Zaretskii [this message]
2022-05-16 23:25   ` समीर सिंह Sameer Singh
2022-05-17  9:49     ` Visuwesh
2022-05-17  9:57       ` समीर सिंह Sameer Singh
2022-05-17 12:11         ` Eli Zaretskii
2022-05-17 13:42           ` Visuwesh
2022-05-17 13:48             ` Visuwesh
2022-05-17 16:04               ` Eli Zaretskii
2022-05-17 16:05             ` Eli Zaretskii
2022-05-17 12:10       ` Eli Zaretskii
2022-05-17 14:10         ` Visuwesh
2022-05-17 16:06           ` Eli Zaretskii
2022-05-17 14:14         ` Visuwesh
2022-05-17 22:59       ` Richard Stallman
2022-05-18  0:14         ` समीर सिंह Sameer Singh
2022-05-18  3:08           ` Pankaj Jangid
2022-05-18  3:41             ` समीर सिंह Sameer Singh
2022-05-18  7:12               ` Pankaj Jangid
2022-05-18 12:51                 ` Eli Zaretskii
2022-05-19  3:14                   ` Pankaj Jangid
2022-05-19  7:12                     ` Eli Zaretskii
2022-05-19 13:40                       ` Pankaj Jangid
2022-05-19 13:58                         ` Eli Zaretskii
2022-05-19 14:31                           ` Visuwesh
2022-05-19 15:52                             ` Eli Zaretskii
2022-05-19 16:32                               ` Pankaj Jangid
2022-05-21  8:06                                 ` Eli Zaretskii
2022-05-18 12:47               ` Eli Zaretskii
2022-05-18 12:45           ` Eli Zaretskii
2022-05-18 13:25             ` Visuwesh
2022-05-18 13:33               ` Eli Zaretskii
2022-05-18 14:58                 ` समीर सिंह Sameer Singh
2022-05-18 15:10                   ` Visuwesh
2022-05-18 15:23                     ` समीर सिंह Sameer Singh
2022-05-19 23:13                       ` Richard Stallman
2022-05-18 15:47                   ` Eli Zaretskii
2022-05-18 16:15                     ` समीर सिंह Sameer Singh
2022-05-18  4:33         ` Visuwesh
2022-05-19 23:13           ` Richard Stallman
2022-05-17 13:24     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y1z1iue4.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55439@debbugs.gnu.org \
    --cc=lumarzeli30@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).