From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: sadiq@sadiqpk.org, monnier@iro.umontreal.ca, 60176@debbugs.gnu.org
Subject: bug#60176: 29.0.60; Fallback file variable mode if treesitter is not usable
Date: Mon, 09 Jan 2023 19:57:50 +0200 [thread overview]
Message-ID: <83y1qboajl.fsf@gnu.org> (raw)
In-Reply-To: <865ydf3dnf.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 09 Jan 2023 19:30:20 +0200)
> From: Juri Linkov <juri@linkov.net>
> Cc: Eli Zaretskii <eliz@gnu.org>, sadiq@sadiqpk.org, 60176@debbugs.gnu.org
> Date: Mon, 09 Jan 2023 19:30:20 +0200
>
> Is it possible at least to make this forward-compatible to support
> such a predicate in future? To enable ts-modes only in some buffers
> currently requires first to enable non-ts-mode, then conditionally ts-mode:
>
> (add-hook 'find-file-hook
> (lambda ()
> (when (and (eq major-mode 'c-mode)
> ;; Unless in internal buffers:
> (not (string-prefix-p " " (buffer-name))))
> (c-ts-mode))))
>
> With a predicate in major-mode-remap-alist it would immediately
> enable the required mode:
>
> (setq major-mode-remap-alist
> '((c-mode . (lambda () (not (string-prefix-p " " (buffer-name))))
> c-ts-mode)))
Why do we need such hoops to jump through? I think we should simply
add
(add-to-list 'auto-mode-alist
'("\\.[ch]\\'" . c-ts-mode))
to c-ts-mode.el (and similarly for C++), and that's it.
next prev parent reply other threads:[~2023-01-09 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-18 12:07 bug#60176: 29.0.60; Fallback file variable mode if treesitter is not usable Mohammed Sadiq
2022-12-19 7:39 ` Juri Linkov
2022-12-19 12:35 ` Eli Zaretskii
2022-12-19 13:12 ` Mohammed Sadiq
2022-12-19 16:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-09 17:30 ` Juri Linkov
2023-01-09 17:57 ` Eli Zaretskii [this message]
2023-01-09 23:06 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-10 12:55 ` Eli Zaretskii
2023-01-10 14:29 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-01-10 18:08 ` Juri Linkov
2023-01-10 18:21 ` Eli Zaretskii
2023-01-16 17:32 ` Juri Linkov
2023-01-16 18:21 ` Eli Zaretskii
2023-01-16 18:36 ` Juri Linkov
2023-01-16 19:26 ` Eli Zaretskii
2023-01-17 7:33 ` Juri Linkov
2023-01-17 12:07 ` Eli Zaretskii
2022-12-19 17:29 ` Juri Linkov
2022-12-19 17:47 ` Eli Zaretskii
2022-12-21 4:35 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1qboajl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60176@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
--cc=sadiq@sadiqpk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).