From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: 64533@debbugs.gnu.org
Subject: bug#64533: [PATCH] Support displaying function name in the header line
Date: Sat, 08 Jul 2023 21:04:30 +0300 [thread overview]
Message-ID: <83y1jqb7pt.fsf@gnu.org> (raw)
In-Reply-To: <ierv8eus2wo.fsf@janestreet.com> (message from Spencer Baugh on Sat, 08 Jul 2023 13:56:23 -0400)
> From: Spencer Baugh <sbaugh@janestreet.com>
> Date: Sat, 08 Jul 2023 13:56:23 -0400
>
> +(defcustom which-func-use-header-line nil
> + "If non-nil, display the function name in the header line."
> + :type '(choice (const :tag "Display in header line" t)
> + (const :tag "Don't display in header line" nil)))
> +
> +(defcustom which-func-use-mode-line t
> + "If non-nil, display the function name in the mode line."
> + :type '(choice (const :tag "Display in mode line" t)
> + (const :tag "Don't display in mode line" nil)))
Defcustom's should have a :version tag.
And why 2 separate defcustom's instead of just one? It looks
un-economical, and also allows for situations in which the behavior is
unclear without examining the code.
Also, I think this needs a NEWS entry, and the user manual should be
amended to account for the new optional display.
Thanks.
next prev parent reply other threads:[~2023-07-08 18:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 17:56 bug#64533: [PATCH] Support displaying function name in the header line Spencer Baugh
2023-07-08 18:04 ` Eli Zaretskii [this message]
2023-07-08 18:14 ` Spencer Baugh
2023-07-08 18:33 ` Eli Zaretskii
2023-07-08 19:26 ` Spencer Baugh
2023-07-08 20:46 ` Andreas Schwab
2023-07-08 20:56 ` Spencer Baugh
2023-07-08 20:58 ` Spencer Baugh
2023-07-09 5:36 ` Eli Zaretskii
2023-07-09 17:26 ` sbaugh
2023-07-15 8:02 ` Eli Zaretskii
2023-07-09 5:29 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1jqb7pt.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=64533@debbugs.gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).