From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64533: [PATCH] Support displaying function name in the header line Date: Sat, 08 Jul 2023 21:04:30 +0300 Message-ID: <83y1jqb7pt.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24850"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64533@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 08 20:05:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qICJ6-0006GF-8W for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Jul 2023 20:05:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qICIp-0004mo-CW; Sat, 08 Jul 2023 14:05:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qICIo-0004me-7o for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 14:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qICIn-0007AR-Vl for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 14:05:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qICIn-0000Pa-Qy for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2023 14:05:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jul 2023 18:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64533-submit@debbugs.gnu.org id=B64533.16888394751514 (code B ref 64533); Sat, 08 Jul 2023 18:05:01 +0000 Original-Received: (at 64533) by debbugs.gnu.org; 8 Jul 2023 18:04:35 +0000 Original-Received: from localhost ([127.0.0.1]:45162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qICIN-0000OM-07 for submit@debbugs.gnu.org; Sat, 08 Jul 2023 14:04:35 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qICIL-0000O0-0i for 64533@debbugs.gnu.org; Sat, 08 Jul 2023 14:04:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qICID-00074V-Vb; Sat, 08 Jul 2023 14:04:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KGzAkiFGaigYod3ShfHQiajVSeux5rfH4S9mF3KtMo0=; b=j45CGvV0Jfmz C5lynaqQhYzJBFlPYIbmn79FIrnPfvJxpTDWSAw+USO+PTejMmC8hnjrma9ts/cW9jwtqbCurZEwZ n4JBYHqQQheUFScc4NZyiHvhLk1znfFpFjqrX+1iUL8p8IbJ2rPDNIxDMnF+iwq1Z4WnQQdsfn6a4 et5QsMJhT/2X3LDQwJ+HYpGZD6WhaNbaLQrZsWt0+JvomlGFlzSMqLU6c28MpMSBtPnETFN0Qys1H Ki6r3NTTjTfCRdbSF8cEveTpZX3Ou7M/0KSPP6YVX9yXm6y61rdwHW4Aoy/MCYVckcOgbLBjViskZ cwUH9FUA/maCNotzfwTdtw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qICIC-0001NR-V0; Sat, 08 Jul 2023 14:04:25 -0400 In-Reply-To: (message from Spencer Baugh on Sat, 08 Jul 2023 13:56:23 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264786 Archived-At: > From: Spencer Baugh > Date: Sat, 08 Jul 2023 13:56:23 -0400 > > +(defcustom which-func-use-header-line nil > + "If non-nil, display the function name in the header line." > + :type '(choice (const :tag "Display in header line" t) > + (const :tag "Don't display in header line" nil))) > + > +(defcustom which-func-use-mode-line t > + "If non-nil, display the function name in the mode line." > + :type '(choice (const :tag "Display in mode line" t) > + (const :tag "Don't display in mode line" nil))) Defcustom's should have a :version tag. And why 2 separate defcustom's instead of just one? It looks un-economical, and also allows for situations in which the behavior is unclear without examining the code. Also, I think this needs a NEWS entry, and the user manual should be amended to account for the new optional display. Thanks.