unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#64971: 30.0.50; string-pixel-width return value is affected by 'line-prefix
@ 2023-07-31 12:02 Ihor Radchenko
  2023-07-31 18:52 ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Ihor Radchenko @ 2023-07-31 12:02 UTC (permalink / raw)
  To: 64971


According to the docstring of `string-pixel-width', it "Return the width
of STRING in pixels."

Consider the following:

(string-pixel-width "asd") ;=> 30
(string-pixel-width (propertize "asd" 'line-prefix "123")) ;=> 60

Should the value of 'line-prefix be appended to the string width?

According to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64696#173,
'line-prefix "does not affect the width of the string itself".

In GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-07-29 built on localhost
Repository revision: ce48073f1597ceecb82800e71c89b53badc9f9d0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: Gentoo Linux

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#64971: 30.0.50; string-pixel-width return value is affected by 'line-prefix
  2023-07-31 12:02 bug#64971: 30.0.50; string-pixel-width return value is affected by 'line-prefix Ihor Radchenko
@ 2023-07-31 18:52 ` Eli Zaretskii
  2023-08-10  9:17   ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2023-07-31 18:52 UTC (permalink / raw)
  To: Ihor Radchenko; +Cc: 64971

> From: Ihor Radchenko <yantar92@posteo.net>
> Date: Mon, 31 Jul 2023 12:02:55 +0000
> 
> 
> According to the docstring of `string-pixel-width', it "Return the width
> of STRING in pixels."
> 
> Consider the following:
> 
> (string-pixel-width "asd") ;=> 30
> (string-pixel-width (propertize "asd" 'line-prefix "123")) ;=> 60

Thanks, should be fixed now on the emacs-29 branch.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#64971: 30.0.50; string-pixel-width return value is affected by 'line-prefix
  2023-07-31 18:52 ` Eli Zaretskii
@ 2023-08-10  9:17   ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-08-10  9:17 UTC (permalink / raw)
  To: yantar92; +Cc: 64971-done

> Cc: 64971@debbugs.gnu.org
> Date: Mon, 31 Jul 2023 21:52:02 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > From: Ihor Radchenko <yantar92@posteo.net>
> > Date: Mon, 31 Jul 2023 12:02:55 +0000
> > 
> > 
> > According to the docstring of `string-pixel-width', it "Return the width
> > of STRING in pixels."
> > 
> > Consider the following:
> > 
> > (string-pixel-width "asd") ;=> 30
> > (string-pixel-width (propertize "asd" 'line-prefix "123")) ;=> 60
> 
> Thanks, should be fixed now on the emacs-29 branch.

No further comments, so I assume the bug is indeed fixed, and I'm
closing it.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-10  9:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-31 12:02 bug#64971: 30.0.50; string-pixel-width return value is affected by 'line-prefix Ihor Radchenko
2023-07-31 18:52 ` Eli Zaretskii
2023-08-10  9:17   ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).