From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 65803@debbugs.gnu.org, shingo.fg8@gmail.com
Subject: bug#65803: 29.1; Noto Sans Mono CJK JP has doubled-width on Windows
Date: Sun, 10 Sep 2023 09:48:58 +0300 [thread overview]
Message-ID: <83y1heseud.fsf@gnu.org> (raw)
In-Reply-To: <877coybmho.fsf@yahoo.com> (message from Po Lu on Sun, 10 Sep 2023 13:55:47 +0800)
> From: Po Lu <luangruo@yahoo.com>
> Cc: shingo.fg8@gmail.com, 65803@debbugs.gnu.org
> Date: Sun, 10 Sep 2023 13:55:47 +0800
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > No, the purpose of FRAME_COLUMN_WIDTH is much more than just "the
> > width of ASCII characters". It is used as the canonical character
> > width of the frame, for gazillion purposes. One example which
> > triggered this bug is :align-to display spec, something utterly
> > unrelated to ASCII characters.
>
> However, the column width has hitherto been defined to the average width
> of the frame font's ASCII characters. At least outside W32, that is.
No! Once again, for fixed-pitch fonts the average width is taken from
the font. Here, from ftfont.c:
if (spacing != FC_PROPORTIONAL
#ifdef FC_DUAL
&& spacing != FC_DUAL
#endif /* FC_DUAL */
)
font->min_width = font->average_width = font->space_width
= (scalable ? ft_face->max_advance_width * size / upEM + 0.5
: ft_face->size->metrics.max_advance >> 6);
else
{
int n;
font->min_width = font->average_width = font->space_width = 0;
for (i = 32, n = 0; i < 127; i++)
if (FT_Load_Char (ft_face, i, FT_LOAD_DEFAULT) == 0)
{
int this_width = ft_face->glyph->metrics.horiAdvance >> 6;
if (this_width > 0
&& (! font->min_width || font->min_width > this_width))
font->min_width = this_width;
if (i == 32)
font->space_width = this_width;
font->average_width += this_width;
n++;
}
if (n > 0)
font->average_width /= n;
}
This clearly only calculates the average width for proportional fonts,
and otherwise takes the average width from the font's max_advance
width without calculating anything. Or what am I missing?
> > But other font back-ends don't compute average_width for fixed-pitch
> > fonts, so are you only talking about proportional fonts here?
>
> I'm talking about fonts in general: since fixed pitch fonts are meant to
> incorporate uniformly sized glyphs, the width of the space glyph should
> represent the average width of any subset of the font's glyphs. In this
> particular case, Fontconfig doesn't deem the font in question a fixed
> pitch font, and thus Emacs measures the average width of each ASCII
> character itself.
See above: other backends only calculate the average width for
proportional fonts. So what you say doesn't fit my reading of the
code.
next prev parent reply other threads:[~2023-09-10 6:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-07 13:38 bug#65803: 29.1; Noto Sans Mono CJK JP has doubled-width on Windows Shingo Tanaka
2023-09-07 13:50 ` Eli Zaretskii
2023-09-07 14:24 ` Shingo Tanaka
2023-09-07 14:40 ` Eli Zaretskii
2023-09-07 14:57 ` Eli Zaretskii
2023-09-07 23:19 ` Shingo Tanaka
2023-09-08 6:25 ` Eli Zaretskii
2023-09-07 22:26 ` Shingo Tanaka
2023-09-08 12:18 ` Eli Zaretskii
2023-09-08 13:42 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-08 14:49 ` Werner LEMBERG
2023-09-09 12:51 ` Eli Zaretskii
2023-09-09 13:42 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-09 14:45 ` Eli Zaretskii
2023-09-09 12:17 ` Eli Zaretskii
2023-09-09 13:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-09 14:39 ` Eli Zaretskii
2023-09-09 14:57 ` Eli Zaretskii
2023-09-10 1:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 5:22 ` Eli Zaretskii
2023-09-10 5:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 5:42 ` Eli Zaretskii
2023-09-10 5:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 6:48 ` Eli Zaretskii [this message]
2023-09-10 7:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 7:53 ` Eli Zaretskii
2023-09-10 7:55 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 8:01 ` Eli Zaretskii
2023-09-10 8:08 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 8:19 ` Eli Zaretskii
2023-09-10 8:31 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 8:50 ` Eli Zaretskii
2023-09-10 9:30 ` Eli Zaretskii
2023-09-10 11:29 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 11:44 ` Eli Zaretskii
2023-09-10 12:09 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-10 12:43 ` Eli Zaretskii
2023-09-10 12:39 ` Shingo Tanaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1heseud.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65803@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
--cc=shingo.fg8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).