bug#57494: `package-install' no longer byte-compiles files of installed packages

bug#57494: `package-install' no longer byte-compiles files of installed packages

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

Originally reported as https://github.com/doublep/eldev/issues/76
but apparently boils down to the fact that Emacs 29 no longer byte-
compiles `.el' files in installed packages. I managed to reproduce the
original problem with `silex/emacs:master' Docker image.

To reproduce with Emacs only:

cat >does-install-byte-compile.el <<EOF
(setf package-user-dir (make-temp-file "emacs-packages" t))
(require 'package)
(package-initialize t)
(package-install 'dash)
(message "%S" (byte-code-function-p (symbol-function '-each)))
EOF

emacs --batch --load does-install-byte-compile.el

If the file is byte-compiled, the last line should read as "t". With all
images I have tested, this is the case. But Emacs 29 (i.e. that `:master'
image), it reads "nil" instead.

Paul

[-- Attachment #2: Type: text/html, Size: 1091 bytes --]

bug#57494: `package-install' no longer byte-compiles files of installed packages

[Lars Ingebrigtsen]

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> If the file is byte-compiled, the last line should read as "t". With all
> images I have tested, this is the case. But Emacs 29 (i.e. that `:master'
> image), it reads "nil" instead.

I tried the recipe (on the current Ubuntu), but the output ended with:

Checking /tmp/emacs-packagesrDHlWK/dash-2.19.1/doc...
Done (Total of 2 files compiled, 2 skipped)
Package ‘dash’ installed.
t

So I'm not able to reproduce it.

You didn't include the output from M-x report-emacs-bug, so I can't say
where you tried this.

bug#57494: `package-install' no longer byte-compiles files of installed packages

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 4145 bytes --]

Here is the output of `report-emacs-bug':

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw3d scroll bars)
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure
 --prefix=/nix/store/fam04cbjqrwhvzg2j35pabikpgf0a9k1-emacs-snapshot-a1fa3d24
 --disable-build-details --with-modules'

Configured features:
CAIRO FREETYPE GIF GLIB GMP GNUTLS GSETTINGS JPEG JSON LCMS2 LIBXML2
MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF
TOOLKIT_SCROLL_BARS WEBP X11 XAW3D XDBE XIM XPM LUCID ZLIB

Important settings:
  locale-coding-system: nil

Major mode:

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  indent-tabs-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail warnings dash rx compile comint
ansi-color ring info easy-mmode bug-reference autoload radix-tree
lisp-mnt tar-mode arc-mode archive-mode cus-edit pp cus-start cus-load
wid-edit mm-archive message yank-media dired dired-loaddefs rfc822 mml
mml-sec epa derived gnus-util text-property-search time-date mailabbrev
gmm-utils mailheader mm-decode mm-bodies mm-encode mail-utils gnutls
network-stream url-http mail-parse rfc2231 rfc2047 rfc2045 mm-util
ietf-drums mail-prsvr url-gw nsm rmc puny url-cache url-auth epg rfc6068
epg-config finder-inf package browse-url url url-proxy url-privacy
url-expand url-methods url-history url-cookie url-domsuf url-util
mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map url-vars seq subr-x
byte-opt bytecomp byte-compile cconv cl-loaddefs cl-lib gv iso-transl
tooltip eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd
tool-bar dnd fontset image regexp-opt fringe tabulated-list replace
newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget keymap hashtable-print-readable backquote threads
inotify lcms2 dynamic-setting system-font-setting font-render-setting
cairo x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 121091 22458)
 (symbols 48 12070 2)
 (strings 32 37331 1171)
 (string-bytes 1 1138807)
 (vectors 16 17191)
 (vector-slots 8 200388 6522)
 (floats 8 32 260)
 (intervals 56 132 0)
 (buffers 992 10))

I pulled updates for the Docker image, still the same result. It
might be that the image is broken, of course, but it used to work
until some 10 days ago:


https://app.circleci.com/pipelines/github/clojure-emacs/cider?branch=master

I also tried with `emacs -Q --batch --load does-install-byte-compile.el',
i.e. adding `-Q' flag. Still fails. Here is the updated recipe:

cat >does-install-byte-compile.el <<EOF
(setf package-user-dir (make-temp-file "emacs-packages" t))
(require 'package)
(package-initialize t)
(package-install 'dash)
(message "%S" (byte-code-function-p (symbol-function '-each)))
(unless (byte-code-function-p (symbol-function '-each))
  (report-emacs-bug "XXX")
  (message "\n%s" (buffer-string)))
EOF

emacs -Q --batch --load does-install-byte-compile.el

Here is how I start the Docker with Emacs image:

$ docker create -it --name emacs --rm silex/emacs:master /bin/bash &&
docker start emacs -ai

For comparison, with image `silex/emacs:28' the installed package is
byte-compiled.

Paul

Paul

[-- Attachment #2: Type: text/html, Size: 4975 bytes --]

bug#57494: `package-install' no longer byte-compiles files of installed packages

[Lars Ingebrigtsen]

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> Here is the output of `report-emacs-bug':
>
> In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0,
> Xaw3d scroll bars)
> System Description: Debian GNU/Linux 11 (bullseye)
>
> Configured using:
>  'configure
>  --prefix=/nix/store/fam04cbjqrwhvzg2j35pabikpgf0a9k1-emacs-snapshot-a1Fa3d24
>  --disable-build-details --with-modules'

Well, that looks pretty similar to mine...  but it's referring to
a1Fa3d24, which is a version from March?  Can you try testing with the
current trunk instead?

bug#57494: `package-install' no longer byte-compiles files of installed packages

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]

Sorry, I assumed that if the image was constantly updated (`docker pull'
always gives me some news), then it is up-to-date. I now tested not with
`master', but at least with something newer than a March version and the
bug is not reproducible there. So, apparently this is an old bug and should
be closed.

I will complain to the image maintainer instead.

Paul

On Thu, 1 Sept 2022 at 12:13, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Paul Pogonyshev <pogonyshev@gmail.com> writes:
>
> > Here is the output of `report-emacs-bug':
> >
> > In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
> version 1.16.0,
> > Xaw3d scroll bars)
> > System Description: Debian GNU/Linux 11 (bullseye)
> >
> > Configured using:
> >  'configure
> >
> --prefix=/nix/store/fam04cbjqrwhvzg2j35pabikpgf0a9k1-emacs-snapshot-a1Fa3d24
> >  --disable-build-details --with-modules'
>
> Well, that looks pretty similar to mine...  but it's referring to
> a1Fa3d24, which is a version from March?  Can you try testing with the
> current trunk instead?
>

[-- Attachment #2: Type: text/html, Size: 1540 bytes --]

bug#57494: `package-install' no longer byte-compiles files of installed packages

[Paul Pogonyshev]

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

By the way, wouldn't it be nice if Emacs included the Git commit somewhere,
at least in unstable versions? In the output it can be seen only
incidentally, because it is included in `configure --prefix ...'. And it's
actually not even guaranteed it is correct.

Paul

On Thu, 1 Sept 2022 at 12:13, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Paul Pogonyshev <pogonyshev@gmail.com> writes:
>
> > Here is the output of `report-emacs-bug':
> >
> > In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
> version 1.16.0,
> > Xaw3d scroll bars)
> > System Description: Debian GNU/Linux 11 (bullseye)
> >
> > Configured using:
> >  'configure
> >
> --prefix=/nix/store/fam04cbjqrwhvzg2j35pabikpgf0a9k1-emacs-snapshot-a1Fa3d24
> >  --disable-build-details --with-modules'
>
> Well, that looks pretty similar to mine...  but it's referring to
> a1Fa3d24, which is a version from March?  Can you try testing with the
> current trunk instead?
>

[-- Attachment #2: Type: text/html, Size: 1424 bytes --]

bug#57494: `package-install' no longer byte-compiles files of installed packages

[Eli Zaretskii]

> Cc: 57494@debbugs.gnu.org
> From: Paul Pogonyshev <pogonyshev@gmail.com>
> Date: Thu, 1 Sep 2022 13:00:41 +0200
> 
> By the way, wouldn't it be nice if Emacs included the Git commit somewhere, at least in unstable versions?

It already does, see emacs-repository-version.

bug#57494: `package-install' no longer byte-compiles files of installed packages

[Lars Ingebrigtsen]

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> Sorry, I assumed that if the image was constantly updated (`docker
> pull' always gives me some news), then it is up-to-date. I now tested
> not with `master', but at least with something newer than a March
> version and the bug is not reproducible there. So, apparently this is
> an old bug and should be closed.

OK; done.

Paul Pogonyshev <pogonyshev@gmail.com> writes:

> By the way, wouldn't it be nice if Emacs included the Git commit
> somewhere, at least in unstable versions? In the output it can be seen
> only incidentally, because it is included in `configure --prefix
> ...'. And it's actually not even guaranteed it is correct.

`M-x report-emacs-bug' does include the repo version by default, but
apparently the image maintainer that you're using has removed it.