unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: pquessev@gmail.com, 58464@debbugs.gnu.org
Subject: bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows
Date: Thu, 13 Oct 2022 13:29:25 +0300	[thread overview]
Message-ID: <83wn949fui.fsf@gnu.org> (raw)
In-Reply-To: <87r0zc88fn.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu,  13 Oct 2022 09:54:52 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: pquessev@gmail.com,  58464@debbugs.gnu.org
> Date: Thu, 13 Oct 2022 09:54:52 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> browse-url-emacs takes any URL, not just file:// URL.
> >> 
> >> (browse-url-emacs "https://gnus.org/") "works fine", except for the same
> >> error messages.
> >
> > But this bug report ius about file:// URLs, not about anything else.
> 
> I've now fixed the general problem, and I think I've also fixed the
> Windows-specific file:-specific problem on the trunk.

Thanks.  But this part:

  -  if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0)
  +  if (save_errno != 0)

might cause us signal an error when VISIT is nil, something that
didn't happen before.

(I also am not sure it is 100% reliable to rely on save_errno being
non-zero whenever we encounter an error, especially in the
file-handlers case.)





  reply	other threads:[~2022-10-13 10:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12  6:43 bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows Pascal Quesseveur
2022-10-12  7:26 ` Eli Zaretskii
2022-10-12 11:10   ` Lars Ingebrigtsen
2022-10-12 13:14     ` Eli Zaretskii
     [not found]   ` <828rlll4ef.fsf@gmail.com>
2022-10-12 13:04     ` Eli Zaretskii
2022-10-12 11:09 ` Lars Ingebrigtsen
2022-10-12 13:13   ` Eli Zaretskii
2022-10-12 13:18     ` Lars Ingebrigtsen
2022-10-12 14:25       ` Eli Zaretskii
2022-10-12 14:42         ` Lars Ingebrigtsen
2022-10-12 15:55           ` Eli Zaretskii
2022-10-12 15:57             ` Lars Ingebrigtsen
2022-10-12 16:07               ` Eli Zaretskii
2022-10-13  7:54                 ` Lars Ingebrigtsen
2022-10-13 10:29                   ` Eli Zaretskii [this message]
2022-10-13 11:30                     ` Lars Ingebrigtsen
2022-10-13 15:44                       ` Eli Zaretskii
2022-10-13 16:40                       ` Paul Eggert
2022-10-13 19:15                         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83wn949fui.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=58464@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=pquessev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).