From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58464: 28.1; browse-url-emacs doesn't work for local files on Windows Date: Thu, 13 Oct 2022 13:29:25 +0300 Message-ID: <83wn949fui.fsf@gnu.org> References: <82k055fsos.fsf@gmail.com> <87y1tlcn7u.fsf@gnus.org> <83czaxchgp.fsf@gnu.org> <87mta1b2p9.fsf@gnus.org> <83sfjtazln.fsf@gnu.org> <87edvdays6.fsf@gnus.org> <83leplavfs.fsf@gnu.org> <871qrdavc6.fsf@gnus.org> <83ilkpauuz.fsf@gnu.org> <87r0zc88fn.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6146"; mail-complaints-to="usenet@ciao.gmane.io" Cc: pquessev@gmail.com, 58464@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 12:31:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oivUo-0001TD-Ei for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 12:31:22 +0200 Original-Received: from localhost ([::1]:42372 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oivUn-0007Hm-8g for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 06:31:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivTX-0006xW-UL for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:30:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60581) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oivTX-0007Pd-JS for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oivTX-0006A8-1o for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 06:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 10:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58464 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 58464-submit@debbugs.gnu.org id=B58464.166565696123617 (code B ref 58464); Thu, 13 Oct 2022 10:30:02 +0000 Original-Received: (at 58464) by debbugs.gnu.org; 13 Oct 2022 10:29:21 +0000 Original-Received: from localhost ([127.0.0.1]:59659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivSr-00068q-70 for submit@debbugs.gnu.org; Thu, 13 Oct 2022 06:29:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oivSp-00068f-Ab for 58464@debbugs.gnu.org; Thu, 13 Oct 2022 06:29:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39072) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivSk-0007JX-2U; Thu, 13 Oct 2022 06:29:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ia/ZiTQfZPeKwLnrPcFQFg6Z/u4aP5Wc8bgt3EAVves=; b=YDJqGQ3fJVoo uaoq2lR2EeeOw33/euvQ3tHFwV7h1EdL3r/ITr4ax2EfKiATk7PMLLZexqaywyzTDeDuO2HesOANe Jm+cEIUBB5VTaG3MqV6vYP9R8s3918mHX2Cut0BIg7uws/IwRATtCjUxaYeer3dEGTyQ1Xao0HJLv /BmCv5i0rO5GvQT8fm9659ybrc8YqyaV2BQ4J6jh1zibMzqtkmyusrKoyYvoBPdXm65m/DfKclz7Q iGDMrTer7GqiQYM6Kspmpaw1MS+7pw+n+9q7L0Wr2hJi7H6tQytVndxaWqLtMAbVoAtpP9mmVW8GB T89pNbaTX+RFVjnHwUtl5w==; Original-Received: from [87.69.77.57] (port=2834 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oivSi-0002MQ-46; Thu, 13 Oct 2022 06:29:13 -0400 In-Reply-To: <87r0zc88fn.fsf@gnus.org> (message from Lars Ingebrigtsen on Thu, 13 Oct 2022 09:54:52 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245286 Archived-At: > From: Lars Ingebrigtsen > Cc: pquessev@gmail.com, 58464@debbugs.gnu.org > Date: Thu, 13 Oct 2022 09:54:52 +0200 > > Eli Zaretskii writes: > > >> browse-url-emacs takes any URL, not just file:// URL. > >> > >> (browse-url-emacs "https://gnus.org/") "works fine", except for the same > >> error messages. > > > > But this bug report ius about file:// URLs, not about anything else. > > I've now fixed the general problem, and I think I've also fixed the > Windows-specific file:-specific problem on the trunk. Thanks. But this part: - if (NILP (handler) && !NILP (visit) && current_buffer->modtime.tv_nsec < 0) + if (save_errno != 0) might cause us signal an error when VISIT is nil, something that didn't happen before. (I also am not sure it is 100% reliable to rely on save_errno being non-zero whenever we encounter an error, especially in the file-handlers case.)