unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#62879: [PATCH] eglot: add dart-ts-mode to eglot-server-programs
@ 2023-04-16  9:14 Mou Tong
  2023-04-16 11:42 ` bug#62879: 回复: " Mou Tong
  0 siblings, 1 reply; 3+ messages in thread
From: Mou Tong @ 2023-04-16  9:14 UTC (permalink / raw)
  To: 62879; +Cc: Mou Tong

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

There is new major [mode] for editing dart files.

It works fine with eglot for me and I hope it can be merged into
Emacs.

[mode]: https://github.com/50ways2sayhard/dart-ts-mode

[-- Attachment #2: 0001-eglot-add-dart-ts-mode-to-eglot-server-programs.patch --]
[-- Type: application/octet-stream, Size: 1427 bytes --]

From ada83af3b68b1417822580841625f67c3e85434d Mon Sep 17 00:00:00 2001
From: dalu <mou.tong@outlook.com>
Date: Sun, 16 Apr 2023 15:54:51 +0800
Subject: [PATCH] eglot: add dart-ts-mode to eglot-server-programs

There is new major [mode] for editing dart files

[mode]: https://github.com/50ways2sayhard/dart-ts-mode
---
 lisp/progmodes/eglot.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 24f2fda5ae5..2797201b703 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -215,8 +215,8 @@ eglot-server-programs
                                 ((R-mode ess-r-mode) . ("R" "--slave" "-e"
                                                         "languageserver::run()"))
                                 ((java-mode java-ts-mode) . ("jdtls"))
-                                (dart-mode . ("dart" "language-server"
-                                              "--client-id" "emacs.eglot-dart"))
+                                ((dart-mode data-ts-mode) . ("dart" "language-server"
+                                                             "--client-id" "emacs.eglot-dart"))
                                 ((elixir-mode elixir-ts-mode heex-ts-mode)
                                  . ,(if (and (fboundp 'w32-shell-dos-semantics)
                                              (w32-shell-dos-semantics))
-- 
2.40.0.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#62879: 回复: [PATCH] eglot: add dart-ts-mode to eglot-server-programs
  2023-04-16  9:14 bug#62879: [PATCH] eglot: add dart-ts-mode to eglot-server-programs Mou Tong
@ 2023-04-16 11:42 ` Mou Tong
  2023-04-18 11:50   ` Eli Zaretskii
  0 siblings, 1 reply; 3+ messages in thread
From: Mou Tong @ 2023-04-16 11:42 UTC (permalink / raw)
  To: Mou Tong; +Cc: 62879@debbugs.gnu.org

[-- Attachment #1: Type: text/plain, Size: 31 bytes --]

My bad, should be this one 😅

[-- Attachment #2: 0001-eglot-add-dart-ts-mode-to-eglot-server-programs.patch --]
[-- Type: application/octet-stream, Size: 1427 bytes --]

From 9cf9e10e894d588eb8bc1b545e22a5aa431fbfd6 Mon Sep 17 00:00:00 2001
From: dalu <mou.tong@outlook.com>
Date: Sun, 16 Apr 2023 15:54:51 +0800
Subject: [PATCH] eglot: add dart-ts-mode to eglot-server-programs

There is new major [mode] for editing dart files

[mode]: https://github.com/50ways2sayhard/dart-ts-mode
---
 lisp/progmodes/eglot.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 24f2fda5ae5..33119ff3bef 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -215,8 +215,8 @@ eglot-server-programs
                                 ((R-mode ess-r-mode) . ("R" "--slave" "-e"
                                                         "languageserver::run()"))
                                 ((java-mode java-ts-mode) . ("jdtls"))
-                                (dart-mode . ("dart" "language-server"
-                                              "--client-id" "emacs.eglot-dart"))
+                                ((dart-mode dart-ts-mode) . ("dart" "language-server"
+                                                             "--client-id" "emacs.eglot-dart"))
                                 ((elixir-mode elixir-ts-mode heex-ts-mode)
                                  . ,(if (and (fboundp 'w32-shell-dos-semantics)
                                              (w32-shell-dos-semantics))
-- 
2.40.0.windows.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#62879: 回复: [PATCH] eglot: add dart-ts-mode to eglot-server-programs
  2023-04-16 11:42 ` bug#62879: 回复: " Mou Tong
@ 2023-04-18 11:50   ` Eli Zaretskii
  0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-04-18 11:50 UTC (permalink / raw)
  To: Mou Tong; +Cc: 62879-done

> Cc: "62879@debbugs.gnu.org" <62879@debbugs.gnu.org>
> From: Mou Tong <mou.tong@outlook.com>
> Date: Sun, 16 Apr 2023 11:42:56 +0000
> msip_labels: 
> 
> My bad, should be this one 😅

Thanks, installed on the emacs-29 branch, and closing the bug.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-04-18 11:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-16  9:14 bug#62879: [PATCH] eglot: add dart-ts-mode to eglot-server-programs Mou Tong
2023-04-16 11:42 ` bug#62879: 回复: " Mou Tong
2023-04-18 11:50   ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).