From: Eli Zaretskii <eliz@gnu.org>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: 66224@debbugs.gnu.org
Subject: bug#66224: [PATCH] Add optional PREDICATE argument to read-directory-name
Date: Fri, 29 Sep 2023 15:05:44 +0300 [thread overview]
Message-ID: <83wmw9yyjr.fsf@gnu.org> (raw)
In-Reply-To: <877coch0q7.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org)
> Date: Tue, 26 Sep 2023 18:16:40 -0700
> From: Joseph Turner via "Bug reports for GNU Emacs,
> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>
> This patch makes read-directory-name accept an optional PREDICATE arg
> so it can be used like read-file-name.
Any rationale?
> @@ -1719,7 +1719,9 @@ combining @var{directory} (or the current buffer's default directory
> if @var{directory} is @code{nil}) and @var{initial}. If both
> @var{default} and @var{initial} are @code{nil}, this function uses
> @var{directory} as substitute default, or the current buffer's default
> -directory if @var{directory} is @code{nil}.
> +directory if @var{directory} is @code{nil}. The union of sixth arg
> +@code{predicate} and @code{file-directory-p} is passed as the
This should be elaborated: what is meant by "the union of sixth arg
and 'file-directory-p'"?
> +@code{predicate} argument to ‘read-file-name’.
^^^^^^^^^^^^^^^^
That should be @code{read-file-name}
> +** 'read-directory-name' now accepts an optional PREDICATE argument.
> +The union of sixth arg PREDICATE and 'file-directory-p' is passed
> +as the PREDICATE argument to 'read-file-name'.
Likewise here, regarding the "union" part.
Also, since you submit the patch for the manual, this NEWS entry
should be marked with "+++".
> Fifth arg INITIAL specifies text to start with.
> DIR should be an absolute directory name. It defaults to
> -the value of `default-directory'."
> +the value of `default-directory'.
> +The union of sixth arg PREDICATE and `file-directory-p' is passed
> +as the PREDICATE argument to `read-file-name'."
The "union" part again.
Thanks.
next prev parent reply other threads:[~2023-09-29 12:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 1:16 bug#66224: [PATCH] Add optional PREDICATE argument to read-directory-name Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-28 9:05 ` Philip Kaludercic
2023-09-29 3:28 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-29 3:28 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-29 3:54 ` Michael Heerdegen
2023-09-29 4:19 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-03 3:30 ` Michael Heerdegen
2023-10-03 23:20 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-05 1:23 ` Michael Heerdegen
2023-10-05 1:34 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-12 20:42 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 10:53 ` Stefan Kangas
2024-01-13 19:26 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-29 12:05 ` Eli Zaretskii [this message]
2023-10-03 23:08 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83wmw9yyjr.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=66224@debbugs.gnu.org \
--cc=joseph@breatheoutbreathe.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).