From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66224: [PATCH] Add optional PREDICATE argument to read-directory-name Date: Fri, 29 Sep 2023 15:05:44 +0300 Message-ID: <83wmw9yyjr.fsf@gnu.org> References: <877coch0q7.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28492"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66224@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 29 14:07:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmCGy-00073I-77 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Sep 2023 14:07:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmCGf-0006A0-7x; Fri, 29 Sep 2023 08:06:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmCGd-00061E-Mc for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 08:06:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmCGd-0007nR-Bq for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 08:06:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmCGr-00042D-Or for bug-gnu-emacs@gnu.org; Fri, 29 Sep 2023 08:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Sep 2023 12:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66224 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66224-submit@debbugs.gnu.org id=B66224.169598919415468 (code B ref 66224); Fri, 29 Sep 2023 12:07:01 +0000 Original-Received: (at 66224) by debbugs.gnu.org; 29 Sep 2023 12:06:34 +0000 Original-Received: from localhost ([127.0.0.1]:55471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmCGP-00041Q-Rq for submit@debbugs.gnu.org; Fri, 29 Sep 2023 08:06:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmCGJ-000413-T4 for 66224@debbugs.gnu.org; Fri, 29 Sep 2023 08:06:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmCFx-0007iF-VX; Fri, 29 Sep 2023 08:06:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=c+f+fCyyV6TYOegqnboqOxNjtq8qeHtOx6mH9mfKTco=; b=NyiCg5tEwUnie5laI8dt KFkQTwVMhA+XcbHDaAr3vcLnchEYumlAjOvWFwt6dchhrqq7+BXTUzq/V/tp8dJM/Smw0lwTXC81D Xf0YdShsA9q/7yS5eoWpvd0KtSK4VbDn6Ks4P/ek9SvDk+DjQJPomwTvv2e3xAdBnuOEbzvFBiifE dFyu7CohW9or72JjV7d5WIf9+6P4uO5K3Z/ZakArlxSsWW+aoq2+OgFXKJkEVnmiHlBWOS9WD9gcv JKmf6LRHkrHoA8ynqiIBYnx+iMv1PIbtkq7KnEboheHx6JHb3l6gsxX7NQ4UopRq9a8jrJd14/heX Uihp6Lwi6kCoJw==; In-Reply-To: <877coch0q7.fsf@breatheoutbreathe.in> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271485 Archived-At: > Date: Tue, 26 Sep 2023 18:16:40 -0700 > From: Joseph Turner via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > This patch makes read-directory-name accept an optional PREDICATE arg > so it can be used like read-file-name. Any rationale? > @@ -1719,7 +1719,9 @@ combining @var{directory} (or the current buffer's default directory > if @var{directory} is @code{nil}) and @var{initial}. If both > @var{default} and @var{initial} are @code{nil}, this function uses > @var{directory} as substitute default, or the current buffer's default > -directory if @var{directory} is @code{nil}. > +directory if @var{directory} is @code{nil}. The union of sixth arg > +@code{predicate} and @code{file-directory-p} is passed as the This should be elaborated: what is meant by "the union of sixth arg and 'file-directory-p'"? > +@code{predicate} argument to ‘read-file-name’. ^^^^^^^^^^^^^^^^ That should be @code{read-file-name} > +** 'read-directory-name' now accepts an optional PREDICATE argument. > +The union of sixth arg PREDICATE and 'file-directory-p' is passed > +as the PREDICATE argument to 'read-file-name'. Likewise here, regarding the "union" part. Also, since you submit the patch for the manual, this NEWS entry should be marked with "+++". > Fifth arg INITIAL specifies text to start with. > DIR should be an absolute directory name. It defaults to > -the value of `default-directory'." > +the value of `default-directory'. > +The union of sixth arg PREDICATE and `file-directory-p' is passed > +as the PREDICATE argument to `read-file-name'." The "union" part again. Thanks.