* bug#67658: filesets can’t open files from menu-bar when using ‘:tree’
@ 2023-12-06 11:17 . shynur
2023-12-16 11:33 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: . shynur @ 2023-12-06 11:17 UTC (permalink / raw)
To: 67658
Reproduce:
PS D:/Tmp> dir
test.txt test.org
PS D:/Tmp> runemacs.exe -Q
(require 'filesets)
(push `("Teest"
. ((:tree ,default-directory ""))) filesets-data)
(filesets-init)
M-x eval-buffer
Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/
Then emacs just gave me an error:
“filesets-files-under: Wrong type argument: stringp, nil”
I expected it to open all the files under that directory.
Am I missing something?
___
v29.1.90 for MS-Windows
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#67658: filesets can’t open files from menu-bar when using ‘:tree’
2023-12-06 11:17 bug#67658: filesets can’t open files from menu-bar when using ‘:tree’ . shynur
@ 2023-12-16 11:33 ` Eli Zaretskii
2023-12-23 9:01 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2023-12-16 11:33 UTC (permalink / raw)
To: . shynur; +Cc: 67658
> From: ". shynur" <one.last.kiss@outlook.com>
> Date: Wed, 6 Dec 2023 11:17:41 +0000
>
> Reproduce:
>
> PS D:/Tmp> dir
> test.txt test.org
> PS D:/Tmp> runemacs.exe -Q
>
> (require 'filesets)
> (push `("Teest"
> . ((:tree ,default-directory ""))) filesets-data)
> (filesets-init)
>
> M-x eval-buffer
>
> Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/
>
> Then emacs just gave me an error:
> “filesets-files-under: Wrong type argument: stringp, nil”
>
> I expected it to open all the files under that directory.
> Am I missing something?
You are not missing anything, this has been broken since Emacs 28.1,
where we installed a change which fixed "normal" invocation of
filesets-open, but broke its invocations from the menu-bar menus. The
breakage was due to omitting from the fix to bug#976 the cautious 'if'
clause in the original author's code.
This should be fixed now on the emacs-29 branch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#67658: filesets can’t open files from menu-bar when using ‘:tree’
2023-12-16 11:33 ` Eli Zaretskii
@ 2023-12-23 9:01 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2023-12-23 9:01 UTC (permalink / raw)
To: one.last.kiss; +Cc: 67658-done
> Cc: 67658@debbugs.gnu.org
> Date: Sat, 16 Dec 2023 13:33:17 +0200
> From: Eli Zaretskii <eliz@gnu.org>
>
> > From: ". shynur" <one.last.kiss@outlook.com>
> > Date: Wed, 6 Dec 2023 11:17:41 +0000
> >
> > Reproduce:
> >
> > PS D:/Tmp> dir
> > test.txt test.org
> > PS D:/Tmp> runemacs.exe -Q
> >
> > (require 'filesets)
> > (push `("Teest"
> > . ((:tree ,default-directory ""))) filesets-data)
> > (filesets-init)
> >
> > M-x eval-buffer
> >
> > Click: Menu-Bar -> File -> Filesets -> 0 Teest -> Tree: d:/Tmp/
> >
> > Then emacs just gave me an error:
> > “filesets-files-under: Wrong type argument: stringp, nil”
> >
> > I expected it to open all the files under that directory.
> > Am I missing something?
>
> You are not missing anything, this has been broken since Emacs 28.1,
> where we installed a change which fixed "normal" invocation of
> filesets-open, but broke its invocations from the menu-bar menus. The
> breakage was due to omitting from the fix to bug#976 the cautious 'if'
> clause in the original author's code.
>
> This should be fixed now on the emacs-29 branch.
No further comments, so I presume the bug was fixed, and I'm closing
it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-23 9:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-06 11:17 bug#67658: filesets can’t open files from menu-bar when using ‘:tree’ . shynur
2023-12-16 11:33 ` Eli Zaretskii
2023-12-23 9:01 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).